fix(generateSearch): prevent #undefined in search URLs when heading lacks id #15784
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue in the documentation search index generator
(
scripts/generateSearch.js) where URLs containing headings without anidattribute would incorrectly include
#undefinedin the final link. This causedbroken navigation when clicking certain results in the documentation search.
What was the problem?
The script assumes all
<h3>tags have anidand always appends#${el.prop('id')}to the generated URL. When theidis missing, URLs like thefollowing were inserted:
What does this PR change?
Adds a null/undefined check before appending URL hash fragments:
#idThis prevents broken URLs in the search index.
Verification
Verified locally by running: