AMP support?

[benlk]

Fallback cases where Pym.js fails to load in the parent

For shortcodes:

• allow the shortcode to be used as a [pym src=""]foo[/pym] that passes the contents to $content to be used as the innards of the placeholder div: <div id="pym_1" class="pym ">foo</div>

For blocks:

• for blocks, the placeholder is a link to the embed

Specific to AMP

For whatever WordPress AMP plugins we want to support:

• provide a transformation that ensures the appropriate Pym JS tags are output as part of the AMP content
• Investigate whether Pym can use amp-iframe as a pymParent: AMP Compatibility nprapps/pym.js#182

[benlk]

https://amp-wp.org/documentation/playbooks/custom-shortcodes-and-widgets/ describes the function is_amp_endpoint() and amp_is_canonical() which we might use with some of the filters added recently to change the output embed code on the page. However, AMP iframe tags aren't 100% compatible with Pym; they use a different postMessage syntax. We'd need to link out to AMP's docs for how to initialize using the amp iframe code versus Pym.js, and we'd need to make these tests ourselves.

[philipjohn]

There's some discussion going on about this in the AMP Project

[claudiulodro]

I have a proposed "good-enough" solution for this at Automattic/newspack-plugin#276. Let me know if you want it in this plugin and I'll open a PR here. I'd definitely prefer to contribute it upstream to this plugin instead of maintaining it as a tweak in Newspack.

[benlk]

@claudiulodro Yes, we'd love to have your PR here.

[claudiulodro]

#62

[benlk]

Thanks! We'll take a look as soon as we can.