-
Notifications
You must be signed in to change notification settings - Fork 2k
Domain Search: Add escape hatch experiment #106836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
ac90a23 to
3e86ab1
Compare
d9a719b to
1a7f959
Compare
402f84f to
56124a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the variants and all of them show correctly according to the experiment. LGTM! Thanks for working on this. Left just a couple of non-blocking comments.
| import { isOnboardingFlow } from '@automattic/onboarding'; | ||
| import { useMemo } from 'react'; | ||
| import { getFlowFromURL } from 'calypso/landing/stepper/utils/get-flow-from-url'; // eslint-disable-line no-restricted-imports | ||
| import { useExperiment } from 'calypso/lib/explat'; // eslint-disable-line no-restricted-imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you had to import the Explat code from Calypso here. I'm not sure if this might have implications for the build process, but everything seems to be working fine, at least in my tests 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, this rule is to avoid circular dependencies. Because Explat is so light, I think this won't be an issue.
packages/domain-search/src/ui/domain-search-skip-suggestion/index.tsx
Outdated
Show resolved
Hide resolved
ExPlat Implementation ChecklistPlease use this checklist as a guide for implementing ExPlat experiments. All PlatformsExPlat profile
Assignment
Eligibility and targeting
Tracking and Events
|
Resolves DOMAINS-1780
Proposed Changes
Why are these changes being made?
This is part of the domain search escape hatch experiment: pbxNRc-5td-p2
Testing Instructions
/setup/onboarding/domainsand search for a domain.controlversion of the experiment:treatment_above_paid_domain_areaby clicking the manual assignmentBookmarklet.treatment_above_paid_domain_areavariation:treatment_paid_domain_area, refresh the page, and make sure you see that variation:treatment_paid_domain_area_free_emphasis, refresh the page, and make sure you see that variation:treatment_paid_domain_area_free_emphasis_extra_cta, refresh the page, and make sure you see that variation:treatment_paid_domain_area_skip_emphasis, refresh the page, and make sure you see that variation:Pre-merge Checklist