Update DIFM theme step #106860
Open
Update DIFM theme step #106860
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 31, 2025 14:55
`MShotsImage` already checks whether `options?.oldHighResImageLoading` is truthy, and if so renders `MShotsImageTreatment` instead of `MShotsImageControl`
…n picker thumbnails
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
xavier-lc
commented
Oct 31, 2025
Comment on lines
-268
to
-280
| if ( options?.oldHighResImageLoading ) { | ||
| return scrollable ? ( | ||
| <div className={ className } style={ style } aria-labelledby={ labelledby }> | ||
| <img ref={ imgRef } className="mshots-dummy-image" aria-hidden="true" alt="" /> | ||
| </div> | ||
| ) : ( | ||
| <img | ||
| ref={ imgRef } | ||
| { ...{ className, style, src, alt, loading } } | ||
| aria-labelledby={ labelledby } | ||
| /> | ||
| ); | ||
| } // else, prettier doesn't like having an else after a return |
There was a problem hiding this comment.
This code was unreachable, MShotsImage already checks whether options?.oldHighResImageLoading is truthy, and if so renders MShotsImageTreatment instead of MShotsImageControl.
matticbot
added
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOTTHEM-62
Proposed Changes
w(the output width) on the mShots settings used for the design picker thumbnails.Why are these changes being made?
Testing Instructions
/start/do-it-for-me/new-or-existing-siteDesignstepPre-merge Checklist