Skip to content

Add maintainer review checklist for Stellar and Soroban issues #17

Description

@El-swaggerito

Description

Difficulty: Expert

Type: Documentation

Summary

Create a maintainer review checklist for Stellar, anchor, payment, and Soroban escrow contributions.

Current Behaviour

Maintainers need a consistent way to review advanced contributor PRs for correctness, test coverage, security, and documentation.

Expected Behaviour

AnchorKit should provide a checklist that maintainers can apply to GrantFox issue reviews.

Suggested Implementation

Document review criteria for Stellar network safety, secret handling, payment validation, anchor lifecycle correctness, Soroban status transitions, tests, and docs.

Files or Areas Likely Affected

  • docs/
  • README.md
  • .github/
  • contracts/treasury-escrow/
  • packages/

Acceptance Criteria

  • Maintainer review checklist is added.
  • Stellar correctness checks are included.
  • Soroban contract checks are included.
  • Secret leakage checks are included.
  • Test and documentation requirements are included.
  • GrantFox reward-readiness review is clearly separated from code approval.

Additional Notes

This should improve review consistency for advanced issues.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked for GrantFox OSS contributionMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Official GrantFox campaign labeldeveloper-experienceDeveloper experience workdocumentationDocumentation workexpertExpert difficultysecuritySecurity sensitive worksorobanSoroban smart contract workstellarStellar ecosystem work

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions