Skip to content

Conversation

@julianmesa-gitkraken
Copy link
Contributor

Fixes and improvements:

  • Releases ThreadSafeFunction callbacks on stop to prevent nodejs event loop from persisting.
  • Improves handling of NSFW options and lifecycle:
    • Enhances robustness in options processing by validating error callback and excluded paths.
    • Ensures proper thread joining and queue management during object destruction to prevent potential crashes.
    • Refines error messages for clarity and user understanding, providing more informative feedback in case of failures.
    • Adds checks to ensure queue and interface are valid before calling methods on them.
  • Refactors excluded path handling and validation:
    • Improves excluded path validation by normalizing paths before comparison, ensuring accurate subdirectory checks.
    • Updates debounceMS validation to include an upper bound, preventing excessively long debounce intervals.
    • Provides a more robust and consistent way of retrieving excluded paths, handling cases where the underlying implementation might not support it.
    • Fixes a bug where file modification detection was not working correctly due to incorrect time comparison.

Enhances robustness in options processing by validating error callback and excluded paths.

Ensures proper thread joining and queue management during object destruction to prevent potential crashes.

Refines error messages for clarity and user understanding, providing more informative feedback in case of failures.

Adds checks to ensure queue and interface are valid before calling methods on them.
@julianmesa-gitkraken julianmesa-gitkraken force-pushed the nodejs-process-doesnt-close-after-stopping branch from 86fb66a to aa85e01 Compare July 28, 2025 19:17
Improves excluded path validation by normalizing paths
before comparison, ensuring accurate subdirectory checks.

Updates debounceMS validation to include an upper bound,
preventing excessively long debounce intervals.

Provides a more robust and consistent way of retrieving
excluded paths, handling cases where the underlying
implementation might not support it.

Fixes a bug where file modification detection was not working
correctly due to incorrect time comparison.
@julianmesa-gitkraken julianmesa-gitkraken force-pushed the nodejs-process-doesnt-close-after-stopping branch from aa85e01 to fdba49b Compare July 28, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant