Upgrade to .NET 9.0 and update Azure SDK, SK and other packages #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DETAILS - Upgraded project from .NET 8.0 to .NET 9.0 across multiple files, including `Directory.Packages.props`, `SharedWebComponents.csproj`, `MinimalApi.csproj`, `ClientApp.csproj`, and various test projects. - Updated several Azure-related packages to newer versions, such as `Azure.AI.OpenAI`, `Azure.Extensions.AspNetCore.Configuration.Secrets`, and `Azure.Identity`. - Modified the Dockerfile to use .NET 9.0 base images for both runtime and build stages. - Replaced `OpenAIClient` with `AzureOpenAIClient` for improved functionality with Azure OpenAI services. - Updated methods for generating embeddings and chat completions to align with new client methods. - Adjusted test files to ensure compatibility with the updated framework and client. - Added XML configuration for SDK resolver settings to manage SDK versions and paths.
luisquintanilla
previously approved these changes
Feb 24, 2025
| var embedding = embeddings.Value.Data.FirstOrDefault()?.Embedding.ToArray() ?? []; | ||
| var embeddingsClient = openAIClient.GetEmbeddingClient(embeddingModelName); | ||
| var embeddings = await embeddingsClient.GenerateEmbeddingAsync(input: section.Content.Replace('\r', ' ')); | ||
| var embedding = embeddings.Value.ToFloats(); // .Value.Data.FirstOrDefault()?.Embedding.ToArray() ?? []; |
There was a problem hiding this comment.
Is the comment at the end of this needed?
There was a problem hiding this comment.
Oh, that was part of the package upgrade tests, deleted the unused comment.
|
Also, I think you might need to update GHA to use .NET 9 as well. I think that's why the build is failing. |
Yes, let me upgrade the actions files to use .NET 9 |
elbruno
commented
Feb 25, 2025
| @@ -16,7 +16,7 @@ jobs: | |||
| - name: Setup .NET | |||
| uses: actions/setup-dotnet@v3 | |||
| with: | |||
| dotnet-version: 8.0.x | |||
| dotnet-version: 9.0.x | |||
There was a problem hiding this comment.
@luisquintanilla upgraded GHAction to build NET 9 projects
Build success https://github.com/Azure-Samples/azure-search-openai-demo-csharp/actions/runs/13531943341/job/37815971710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Directory.Packages.props,SharedWebComponents.csproj,MinimalApi.csproj,ClientApp.csproj, and various test projects.Azure.AI.OpenAI,Azure.Extensions.AspNetCore.Configuration.Secrets, andAzure.Identity.OpenAIClientwithAzureOpenAIClientfor improved functionality with Azure OpenAI services.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?