Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenTelemetry and loadtesting via Locust #65

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

pamelafox
Copy link
Contributor

Purpose

Fixes #50

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

@@ -29,14 +32,15 @@ class State(TypedDict):


@asynccontextmanager
async def lifespan(app: FastAPI) -> AsyncIterator[State]:
async def lifespan(app: fastapi.FastAPI) -> AsyncIterator[State]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change necessary due to configure_azure_monitor only working with "import fastapi"

@pamelafox pamelafox merged commit f76747a into main Jul 23, 2024
14 checks passed
@pamelafox pamelafox deleted the otel branch July 23, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with AppInsights Not Recording Metrics in Azure Deployment
1 participant