451 uris in parameters (#553)

* Allowing Hardcoded URLs within Parameters.  Fixing #451

* Adding unit test for URIs in parameters (re #451)

* Updating test (.Index, not .StartIndex)

* Fixing unknown api version in deployments (false negative)

Co-authored-by: James Brundage <@github.com>

Author: StartAutomating

arm-ttk/testcases/deploymentTemplate/DeploymentTemplate-Must-Not-Contain-Hardcoded-Uri.test.ps1

@@ -51,6 +51,9 @@ $preceededBySchema = # The exception to the rule is a schema reference,
 
 # Exception Regexs (end)
 
+$parametersSection = Resolve-JSONContent -JSONPath "parameters" -JSONText $TemplateText
+
+
 # Walk thru each host reference found 
 foreach ($match in $HardcodedHostFinder.Matches($TemplateText)) { 
 
@@ -62,6 +65,16 @@ foreach ($match in $HardcodedHostFinder.Matches($TemplateText)) {
     $devOpsGalleryMatch = $IsDevOpsGalleryStorage.Match($templateText, $match.Index)
     $notTheDevOpsGallery = (-not $devOpsGalleryMatch.Success -or $devOpsGalleryMatch.Index + $devOpsGalleryMatch.Length -ne $match.Index)
 
+    
+    if ($parametersSection -and # If there was a parameters section, 
+        (                       # and the url occured within it                  
+            $match.Index -ge $parametersSection.Index -and 
+            $match.Index -lt ( $parametersSection.Index  + $parametersSection.Length)
+        )
+    ) {
+        continue                # this is not a problem.  Move onto the next match.
+    }
+
     if ($notTheDevOpsGallery -and 
         $notTheSchema 
         ) { 

unit-tests/DeploymentTemplate-Must-Not-Contain-Hardcoded-Uri/Pass/Uri-In-Parameters.json

@@ -0,0 +1,12 @@
+{
+  "$schema": "https://schema.management.azure.com/schemas/2019-08-01/managementGroupDeploymentTemplate.json#",
+  "contentVersion": "1.0.0.0",
+  "parameters": {
+    "MicrosftDotCom": {
+      "type": "string",
+      "metadata": {
+        "description": "https://graph.windows.net/"
+      }
+    }
+  }
+}