Skip to content

Commit bcd6fb7

Browse files
authored
feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD (#3925)
* feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD * fix: Fixed the lint error from the pipeline * fix: Fixed the CRD Generation error from the pipelines * fix: Updated the name to be specific that we require the subnet Guid and not ARM ID * fix: Keeping the IP Range field as optional * fix: Making the App Gateway Subnet ID field as optional to avoid breaking existing clusters where this field is not populated * fix: Updated CRD to fix CRDGen Error
1 parent 969e8e0 commit bcd6fb7

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,15 @@ type OverlayExtensionConfigList struct {
3434
// +kubebuilder:validation:XValidation:rule="!has(oldSelf.extensionIPRange) || has(self.extensionIPRange)", message="ExtensionIPRange is required once set"
3535
type OverlayExtensionConfigSpec struct {
3636
// ExtensionIPRange field defines a CIDR that should be able to reach routing domain ip addresses.
37-
// +kubebuilder:validation:Optional
3837
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
3938
// +kubebuilder:validation:MaxLength=43
4039
// 43 is max length of IPv6 CIDR string
4140
ExtensionIPRange string `json:"extensionIPRange,omitempty"`
41+
42+
// AppGatewaySubnetGUID field defines a subnet delegated to Application Gateway that should be able to reach routing domain ip addresses. This needs to be a valid GUID.
43+
// +kubebuilder:validation:Optional
44+
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
45+
AppGatewaySubnetGUID string `json:"appGatewaySubnetGUID,omitempty"`
4246
}
4347

4448
type OECState string

crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,14 @@ spec:
4747
spec:
4848
description: OverlayExtensionConfigSpec defines the desired state of OverlayExtensionConfig.
4949
properties:
50+
appGatewaySubnetGUID:
51+
description: AppGatewaySubnetGUID field defines a subnet delegated
52+
to Application Gateway that should be able to reach routing domain
53+
ip addresses. This needs to be a valid GUID.
54+
type: string
55+
x-kubernetes-validations:
56+
- message: Value is immutable
57+
rule: self == oldSelf
5058
extensionIPRange:
5159
description: |-
5260
ExtensionIPRange field defines a CIDR that should be able to reach routing domain ip addresses.

0 commit comments

Comments
 (0)