Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] HTTP spans have wrong parent in ApplicationInsights #22272

Closed
3 tasks done
lmolkova opened this issue Jun 14, 2021 · 3 comments
Closed
3 tasks done

[BUG] HTTP spans have wrong parent in ApplicationInsights #22272

lmolkova opened this issue Jun 14, 2021 · 3 comments
Assignees
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Jun 14, 2021

Note this is likely azure-core issue, not related to storage

Describe the bug
HTTP span is reported as child of incoming request, not the logical downloadBlob in SpringBoot app

Here is the transaction

Exception or Stack Trace
N/A

To Reproduce

  1. create a simple SpringBoot app
  2. in the controller make a call to upload blob
  3. deploy to azure app service
  4. configure app insights on the app-service
  5. enable Azure SDK collection

Code Snippet

	@RequestMapping("/")
		BlobClient blobClient = this.containerClient.getBlobClient("blob" + System.currentTimeMillis());
		blobClient.upload(BinaryData.fromString("test"));

		return "Greetings from Spring Boot!";
	}

Expected behavior
http span (azmondemo) should be child of upload blob span

Screenshots
image

Setup (please complete the following information):

  • OS: Linux
  • IDE: IntelliJ
  • Library/Libraries: azure-core:1.17.0

Additional context

Information Checklist

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 14, 2021
@alzimmermsft alzimmermsft added the Client This issue points to a problem in the data-plane of the library. label Jun 14, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 14, 2021
@lmolkova lmolkova self-assigned this Jun 14, 2021
@lmolkova lmolkova changed the title [BUG] Blob storage HTTP spans have wrong parent in ApplicationInsights [BUG] HTTP spans have wrong parent in ApplicationInsights Jun 14, 2021
@joshfree joshfree added the Azure.Core azure-core label Jun 16, 2021
@lmolkova
Copy link
Member Author

lmolkova commented Jun 16, 2021

Investigation

All users who use agent (AppInsight or OTel) are affected

  • Azure Core produces spans as expected: logical (upload blob) and physical HTTP PUT as a child
  • Bytecode instrumentation agent adds another HTTP PUT span
  • ApplicationInsights SDK suppresses Azure SDK Http span (which is a duplicate of the above)

Here's how it looks in Zipkin

image

Action items

/cc @trask

@lmolkova lmolkova added this to the [2021] July milestone Jun 23, 2021
@lmolkova
Copy link
Member Author

ApplicationInsights agent issue does not affect new agent 3.1.1+ if there is no azure-core-tracing-opentelemetry.

If user installs it AND enables otel api support, there is duplication

image

@lmolkova
Copy link
Member Author

Fixed in OpenTelemetry Java agent v1.12.0

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
Status: Done
Development

No branches or pull requests

3 participants