Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ChatRequestUserMessage json roundtrip #44094

Open
vnesterovsky opened this issue Feb 8, 2025 · 1 comment
Open

[BUG] ChatRequestUserMessage json roundtrip #44094

vnesterovsky opened this issue Feb 8, 2025 · 1 comment
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@vnesterovsky
Copy link

vnesterovsky commented Feb 8, 2025

Please consider a class ChatRequestUserMessage and similars.

Consider roundtrip fromJson() -> toJson().

Consider the behavior of content field:

  • In fromJson() content reaches content field as a BinaryData, while fields stringContent and chatMessageContentItems remain null.
  • In toJson() only stringContent and chatMessageContentItems are inspected, so final json has no content at all.

This makes it rather untrivial task to get whole payload from json and convert into a proper instance of
ChatCompletionsOptions.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 8, 2025
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 11, 2025
@joshfree
Copy link
Member

@jpalvarezl could you please follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants