[Do Not Merge] Defensive mechanism for lease renewal #46875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2115e36.
* add cfp logs * react to comments * react to comments * react to comments * react to comments * add log line for release errors
…edRangeCacheRefresh [Spark]SupportSystemPropertyForFeedRangeCacheRefreshInterval
…range read feed (Azure#21) * Added a way to limit prefetch and page size for ReadFeed of PartitionKeyRange. * Added additional logging. * Added additional logging. * Added additional logging. * DOUBLE CHECK IMPACT - comment out feed range refresh interval setting * Addressing review comments. * Addressing review comments. * Addressing review comments. * Addressing review comments. * Addressing review comments. * Disable fault injection CFP test. * Addressing review comments.
…eshInterval fixTests
…geCacheForCFP AddWireup using partition key range cache for cfp
…zure#23) * Added a way to limit prefetch and page size for ReadFeed of PartitionKeyRange. * Added additional logging. * Added additional logging. * Added additional logging. * DOUBLE CHECK IMPACT - comment out feed range refresh interval setting * Addressing review comments. * Addressing review comments. * Addressing review comments. * Addressing review comments. * Addressing review comments. * Disable fault injection CFP test. * Addressing review comments. * Revert Spark test fixes.
…Planning-dev improvePerfDuringPartitionPlanning
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
reviewed
Sep 29, 2025
| } | ||
|
|
||
| return this.partitionKeyRangeCache.tryLookupAsync(BridgeInternal.getMetaDataDiagnosticContext(request.requestContext.cosmosDiagnostics), documentCollectionValueHolder.v.getResourceId(), null, null) | ||
| StringBuilder sb = new StringBuilder("RxDocumentClientImpl.createDocumentInternal:").append(","); |
Member
There was a problem hiding this comment.
I do not think we want to check in the log change in master, maybe have one PR only includes the defensive mechanism change?
Member
Author
|
/azp run java - cosmos - tests |
Member
Author
|
/azp run java - cosmos - kafka |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change feed processor will now stop renewing a lease if after 25 * the lease renewal interval there haven't been any results processed. This should allow for another worker to pick up this lease.
Implementation
PartitionSupervisorImpl already has the logic for stopping the renew and processing threads for a partition for exceptions. This was extended to stop both the processing and renewing threads when a change hasn't being processed after 25 * the lease renewal interval. The last processed time tracked is taking after we receive a response from change feed.