[changelog tool] Report added operation group classes correctly in changelog#48110
Merged
Conversation
Newly added operation group classes (e.g. PrivateLinkResourcesOperations) were mislabeled as 'Added model'. Detect operation group classes by name ending with 'operations' in an operations module and emit 'Added operation group' instead, removing the need for manual changelog optimization. Fixes #48107 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc14cf8a-5eef-4d13-9581-59d1e5491585
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects changelog classification for newly added operation-group classes.
Changes:
- Adds a dedicated operation-group class change type and message.
- Detects operation groups by class and module naming conventions.
- Tests correct labeling and sync/async deduplication.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/breaking_changes_checker/changelog_tracker.py |
Reports operation-group classes correctly. |
scripts/breaking_changes_checker/breaking_changes_tracker.py |
Adds operation-group detection. |
scripts/breaking_changes_checker/tests/test_changelog.py |
Covers classification and deduplication. |
The four added operation group classes are now reported as 'Added operation group' instead of 'Added model'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc14cf8a-5eef-4d13-9581-59d1e5491585
ChenxiJiang333
approved these changes
Jul 17, 2026
msyyc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For #48107
The changelog generation tool (
scripts/breaking_changes_checker) mislabeled newly added operation group classes as models. For example, addingPrivateLinkResourcesOperationsproduced:The second line is wrong — an operation group is not a model — and previously had to be corrected manually in a post-generation optimization step.
Changes
changelog_tracker.py: addedChangeType.ADDED_OPERATION_GROUP_CLASSandADDED_OPERATION_GROUP_CLASS_MSG = "Added operation group \{}`", and a new branch inrun_non_breaking_class_level_diff_checks()that emits it for operation group classes instead ofAdded model`.breaking_changes_tracker.py: addedis_operation_group()helper that recognizes an operation group class by name ending withoperations(case-insensitive, covering the defaultOperationsclass too) and being defined in an operations module (module name ending withoperations), consistent with the existingattr_type.lower().endswith("operations")convention used elsewhere.run_async_cleanupalready collapses the sync/aioduplicate since its dedup key excludes the module name.Testing
test_added_operation_group_class_not_labeled_as_modelverifying exactly oneAdded operation groupentry (sync/async collapsed) and zeroAdded modelentries.pytest tests/test_changelog.py— 22 passed, 1 skipped.pytest tests/test_breaking_changes.py— 19 passed, 1 skipped.