1111namespace AutoRest . Swagger . Tests
1212{
1313 /// <summary>
14- /// This class contains tests for the logic comparing two swagger specifications,
14+ /// This class contains tests for the logic comparing two swagger specifications,
1515 /// an older version against newer version.
16- ///
17- /// For all but the tests that verify that version checks are done properly, the
16+ ///
17+ /// For all but the tests that verify that version checks are done properly, the
1818 /// old and new specifications have the same version number, which should force
1919 /// the comparison logic to produce errors rather than warnings for each breaking
2020 /// change.
21- ///
21+ ///
2222 /// Non-breaking changes are always presented as informational messages, regardless
2323 /// of whether the version has changed or not.
2424 /// </summary>
@@ -169,10 +169,10 @@ public void PathRemoved()
169169 /// </summary>
170170 [ Fact ]
171171 public void OperationRemoved ( )
172- {
172+ {
173173 var messages = CompareSwagger ( "removed_operation.json" ) . ToArray ( ) ;
174174 var missing = messages . Where ( m => m . Id == ComparisonMessages . RemovedOperation . Id ) ;
175- Assert . Equal ( 1 , missing . Count ( ) ) ;
175+ Assert . Single ( missing ) ;
176176 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Error && m . Path . ReadablePath == "#/paths/api/Operations" ) ) ;
177177 }
178178
@@ -197,11 +197,11 @@ public void AddedPaths()
197197 {
198198 var messages = CompareSwagger ( "added_path.json" ) . ToArray ( ) ;
199199 var missing = messages . Where ( m => m . Id == ComparisonMessages . AddedPath . Id ) ;
200- Assert . Equal ( 1 , missing . Count ( ) ) ;
200+ Assert . Single ( missing ) ;
201201 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Info && m . Path . ReadablePath == "#/paths/api/Paths" ) ) ;
202202
203203 missing = messages . Where ( m => m . Id == ComparisonMessages . AddedOperation . Id ) ;
204- Assert . Equal ( 1 , missing . Count ( ) ) ;
204+ Assert . Single ( missing ) ;
205205 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Info && m . Path . ReadablePath == "#/paths/api/Operations/post" ) ) ;
206206 }
207207
@@ -213,7 +213,7 @@ public void RequiredParameterRemoved()
213213 {
214214 var messages = CompareSwagger ( "required_parameter.json" ) . ToArray ( ) ;
215215 var missing = messages . Where ( m => m . Id == ComparisonMessages . RemovedRequiredParameter . Id ) ;
216- Assert . Equal ( 1 , missing . Count ( ) ) ;
216+ Assert . Single ( missing ) ;
217217 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Error && m . Path . ReadablePath == "#/paths/api/Parameters/{a}/get/f" ) ) ;
218218 }
219219
@@ -253,7 +253,7 @@ public void RequiredParameterAdded()
253253 {
254254 var messages = CompareSwagger ( "required_parameter.json" ) . ToArray ( ) ;
255255 var missing = messages . Where ( m => m . Id == ComparisonMessages . AddingRequiredParameter . Id ) ;
256- Assert . Equal ( 1 , missing . Count ( ) ) ;
256+ Assert . Single ( missing ) ;
257257 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Error && m . Path . ReadablePath == "#/paths/api/Parameters/{a}/get/g" ) ) ;
258258 }
259259
@@ -265,7 +265,7 @@ public void ReadonlyPropertyInResponse()
265265 {
266266 var messages = CompareSwagger ( "readonly_changes.json" ) . ToArray ( ) ;
267267 var missing = messages . Where ( m => m . Id == ComparisonMessages . AddedReadOnlyPropertyInResponse . Id ) ;
268- Assert . Equal ( 1 , missing . Count ( ) ) ;
268+ Assert . Single ( missing ) ;
269269 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Info && m . Path . ReadablePath == "#/paths/subscriptions/{subscriptionId}/providers/Microsoft.Storage/checkNameAvailability/post/200/properties" ) ) ;
270270 }
271271
@@ -277,13 +277,14 @@ public void AddedPropertyInResponse()
277277 {
278278 var messages = CompareSwagger ( "added_property_in_response.json" ) . ToArray ( ) ;
279279 var missing = messages . Where ( m => m . Id == ComparisonMessages . AddedPropertyInResponse . Id ) ;
280- Assert . Equal ( 1 , missing . Count ( ) ) ;
280+ Assert . Single ( missing ) ;
281281 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Error && m . Path . ReadablePath == "#/paths/subscriptions/{subscriptionId}/providers/Microsoft.Storage/checkNameAvailability/post/200/properties" ) ) ;
282282 }
283283
284284 /// <summary>
285285 /// Verifies that rules work on the recurive models
286286 /// </summary>
287+ [ Fact ]
287288 public void RecursiveModels ( )
288289 {
289290 var messages = CompareSwagger ( "recursive_model.json" ) . ToArray ( ) ;
@@ -330,7 +331,7 @@ public void ParameterStatusLess()
330331 {
331332 var messages = CompareSwagger ( "required_parameter.json" ) . ToArray ( ) ;
332333 var missing = messages . Where ( m => m . Id == ComparisonMessages . RequiredStatusChange . Id ) ;
333- Assert . Equal ( 1 , missing . Count ( ) ) ;
334+ Assert . Single ( missing ) ;
334335 Assert . NotEmpty ( missing . Where ( m => m . Severity == Category . Error && m . Path . ReadablePath == "#/paths/api/Parameters/{a}/get/e" ) ) ;
335336 }
336337
@@ -443,7 +444,7 @@ public void ResponseSchemaChanged()
443444 {
444445 var messages = CompareSwagger ( "operation_check_02.json" ) . ToArray ( ) ;
445446 var removed = messages . Where ( m => m . Id == ComparisonMessages . TypeChanged . Id && m . Path . JsonReference . Contains ( "Responses" ) ) . ToArray ( ) ;
446- Assert . Equal ( 1 , removed . Length ) ;
447+ Assert . Single ( removed ) ;
447448 Assert . Equal ( Category . Error , removed [ 0 ] . Severity ) ;
448449 Assert . Equal ( "#/paths/~1api~1Responses/get/400/properties/id" , removed [ 0 ] . Path . JsonReference ) ;
449450 }
@@ -456,7 +457,7 @@ public void ResponseHeaderAdded()
456457 {
457458 var messages = CompareSwagger ( "operation_check_03.json" ) . ToArray ( ) ;
458459 var added = messages . Where ( m => m . Id == ComparisonMessages . AddingHeader . Id ) . ToArray ( ) ;
459- Assert . Equal ( 1 , added . Length ) ;
460+ Assert . Single ( added ) ;
460461 Assert . Equal ( Category . Info , added [ 0 ] . Severity ) ;
461462 Assert . Equal ( "#/paths/~1api~1Responses/get/200/x-c" , added [ 0 ] . Path . JsonReference ) ;
462463 }
@@ -469,7 +470,7 @@ public void ResponseHeaderRemoved()
469470 {
470471 var messages = CompareSwagger ( "operation_check_03.json" ) . ToArray ( ) ;
471472 var removed = messages . Where ( m => m . Id == ComparisonMessages . RemovingHeader . Id ) . ToArray ( ) ;
472- Assert . Equal ( 1 , removed . Length ) ;
473+ Assert . Single ( removed ) ;
473474 Assert . Equal ( Category . Error , removed [ 0 ] . Severity ) ;
474475 Assert . Equal ( "#/paths/~1api~1Responses/get/200/x-a" , removed [ 0 ] . Path . JsonReference ) ;
475476 }
@@ -482,7 +483,7 @@ public void ResponseHeaderTypeChanged()
482483 {
483484 var messages = CompareSwagger ( "operation_check_03.json" ) . ToArray ( ) ;
484485 var changed = messages . Where ( m => m . Id == ComparisonMessages . TypeChanged . Id && m . Path . JsonReference . Contains ( "Responses" ) ) . ToArray ( ) ;
485- Assert . Equal ( 1 , changed . Length ) ;
486+ Assert . Single ( changed ) ;
486487 Assert . Equal ( Category . Error , changed [ 0 ] . Severity ) ;
487488 Assert . Equal ( "#/paths/~1api~1Responses/get/200/x-b" , changed [ 0 ] . Path . JsonReference ) ;
488489 }
@@ -647,7 +648,7 @@ public void GlobalResponseTypeConstraintsChanged()
647648 public void RemovedPropertyTest ( )
648649 {
649650 var messages = CompareSwagger ( "removed_property.json" ) . ToArray ( ) ;
650- Assert . Equal ( true , messages . Where ( m => m . Id == ComparisonMessages . RemovedProperty . Id ) . Any ( ) ) ;
651+ Assert . True ( messages . Where ( m => m . Id == ComparisonMessages . RemovedProperty . Id ) . Any ( ) ) ;
651652 }
652653 }
653654}
0 commit comments