You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Turns out max_sentence_length (MAXSENTLEN) is not really the maximum
sentence length but two more than it (yikes). See issue #32.
first-stage/PARSE/parseIt.C: fix check to avoid segfaults for sentence
lengths one fewer than user-requested maximum length.
python/bllipparser/RerankingParser.py: fixed similar check as above
python/tests/test_reranking_parser.py: added long sentence tests
It seems that there are (at least) two off-by-one errors with these calculations:
The obvious workaround is to only parse things that are two fewer than the maximum sentence length (unlikely to be much of an issue in practice).
The text was updated successfully, but these errors were encountered: