Confusing response behaviour.

Author: alistairjevans

ext/hyper_ruby/src/response.rs

@@ -59,8 +59,12 @@ impl Response {
         // copy back from the hyper body to the ruby string; doesn't need to be performant,
         // only used in tests
         let body = self.response.body();
-        let frame = body.clone().frame().now_or_never().unwrap().unwrap().unwrap();
-        let data_chunk = frame.into_data().unwrap();
-        RString::from_slice(data_chunk.iter().as_slice())
+        match body.clone().frame().now_or_never() {
+            Some(frame) => {
+                let data_chunk = frame.unwrap().unwrap().into_data().unwrap();
+                RString::from_slice(data_chunk.iter().as_slice())
+            }
+            None => RString::buf_new(0),
+        }
     }
 }

test/test_hyper_ruby.rb

@@ -64,12 +64,12 @@ def test_unix_socket_cleans_up_socket
     end
   end
 
-  def test_blocking
-    buffer = String.new(capacity: 1024)
-    with_server(-> (request) { handler_accept(request, buffer) }) do |client|
-      gets
-    end
-  end
+  # def test_blocking
+  #   buffer = String.new(capacity: 1024)
+  #   with_server(-> (request) { handler_accept(request, buffer) }) do |client|
+  #     gets
+  #   end
+  # end
 
   def with_server(request_handler, &block)
     server = HyperRuby::Server.new

test/test_response.rb

@@ -12,4 +12,11 @@ def test_can_read_properties_back
     assert_equal 'Hello, world!', response.body
   end
 
+  def test_can_read_property_with_empty_body
+    response = HyperRuby::Response.new(200, { 'Content-Type' => 'text/plain' }, '')
+    assert_equal 200, response.status
+    assert_equal 'text/plain', response.headers['content-type']
+    assert_equal '', response.body
+  end
+
 end