Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions #625

Open
7 of 10 tasks
ljgarcia opened this issue Dec 20, 2022 · 3 comments
Open
7 of 10 tasks

Update GitHub actions #625

ljgarcia opened this issue Dec 20, 2022 · 3 comments
Assignees
Labels
website issues/changes to website

Comments

@ljgarcia
Copy link
Contributor

ljgarcia commented Dec 20, 2022

Hi @sahar-frikha
After processing the first PR coming from the GitHub actions, if have noticed the following

  • The hierarchy is empty (we have talked about it already)
  • The link to the DataCatalog use cases is wrong. Are use cases in configuration file? If yes, update info for DataCatalog, it should be /useCases/DataRepository
  • The link to the FormalParameter use cases is wrong. Are use cases in configuration file? If yes, it should be /useCases/ComputationalWorkflow
  • The link to the TaxonName use cases is wrong. Are use cases in configuration file? If yes, it should be /useCases/Taxon
  • The link to the SequenceAnnotation use cases is wrong. Are use cases in configuration file? If yes, it should be /useCases
    /Protein
  • The link to the SequenceRange use cases is wrong. Are use cases in configuration file? If yes, it should be /useCases/Protein
  • The link to the ProteinStructure use cases is wrong. Are use cases in configuration file? If yes, it should be /useCases/Protein
  • The redirection in the new draft profile file includes quotation marks so it is not interpreted as a redirection but as text.
  • Dates with only one digit should have two, e.g., 202351 should be 20230501
  • Release should have status: 'release' rather than 'deprecated'

Redirection looks like

redirect_from: '- "/specifications/Dataset/"

  - "/specifications/Dataset"

  - "/profiles/Dataset/"

  - "/profiles/Dataset"

  - "/devSpecs/Dataset/specification/"

  - "/devSpecs/Dataset/specification"

  - "/devSpecs/Dataset/"

  - "/devSpecs/Dataset"

  - "/specifications/drafts/Dataset/"

  - "/specifications/drafts/Dataset"'

But it should be like

redirect_from:
- "/specifications/Dataset/"
- "/specifications/Dataset"
- "/profiles/Dataset/"
- "/profiles/Dataset"
- "/devSpecs/Dataset/specification/"
- "/devSpecs/Dataset/specification"
- "/devSpecs/Dataset/"
- "/devSpecs/Dataset"
- "/specifications/drafts/Dataset/"
- "/specifications/drafts/Dataset"
@ljgarcia ljgarcia added the website issues/changes to website label Dec 20, 2022
@ljgarcia
Copy link
Contributor Author

Hi @albangaignard all issues sorted out except for the quotation marks for the redirection, please see above. Thanks

@ljgarcia
Copy link
Contributor Author

Hi @albangaignard one new issue came about GitHub Actions

I got an error that I easily fix but could be an indicative of something on the DDE or Actions side (@gtsueng had a look on the DDE side and she has confirmed that no dates are created there)

  Liquid Exception: Invalid Date: '"202346T165753"' is not a valid datetime. in /home/ubuntu/workspace/bioschemas.github.io/_layouts/profiles.html
             ERROR: YOUR SITE COULD NOT BE BUILT:
                    ------------------------------------
                    Invalid Date: '"202346T165753"' is not a valid datetime.
                    ------------------------------------------------
      Jekyll 4.3.1   Please append `--trace` to the `serve` command
                     for any additional information or backtrace.
                    ------------------------------------------------

@albangaignard
Copy link
Collaborator

albangaignard commented May 22, 2023

I found the quotes in this file : https://github.com/BioSchemas/bioschemas.github.io/blob/master/_data/metadata_mapping.csv . @ljgarcia @gtsueng do you know how it is generated ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website issues/changes to website
Projects
None yet
Development

No branches or pull requests

3 participants