Skip to content

bug: binder_design.ipynb hardcodes stale app name "esmfold2-design-jun1-12pm" causing NotFoundError #334

@Shallowidea

Description

@Shallowidea

Bug

The notebook cookbook/tutorials/binder_design.ipynb references a hardcoded
app name with a timestamp suffix that does not match the app name defined in
binder_design.py, causing a NotFoundError when running the "App setup" cell.

Steps to reproduce

  1. Deploy following the notebook instructions: modal deploy binder_design.py
  2. Run the "App setup" cell in the notebook
  3. Run any app.design.spawn(...) call

Error

NotFoundError: Lookup failed for Cls 'ESMFold2DesignModal' from the
'esmfold2-design-jun1-12pm' app (in the 'main' environment):
App 'esmfold2-design-jun1-12pm' not found in environment 'main'.

Root cause

In binder_design.ipynb, the "App setup" cell contains:

ESMFold2Design = modal.Cls.from_name("esmfold2-design-jun1-12pm", "ESMFold2DesignModal")

But binder_design.py defines the app as:

app = modal.App(name="esmfold2-design", ...)

The -jun1-12pm suffix appears to be a leftover from internal testing
and was not cleaned up before release.

Fix

# cookbook/tutorials/binder_design.ipynb — App setup cell
ESMFold2Design = modal.Cls.from_name("esmfold2-design", "ESMFold2DesignModal")

Environment

  • Tested on Modal Notebooks
  • esm installed from git+https://github.com/Biohub/esm.git@main
  • Confirmed working after applying the fix above

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions