Skip to content

Commit e480f8d

Browse files
Use features from luigi >= 3.1 instead of luigi-tools (#26)
1 parent 4687912 commit e480f8d

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

data_validation_framework/task.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@
1111
import pandas as pd
1212
from luigi.parameter import ChoiceParameter
1313
from luigi.parameter import DictParameter
14+
from luigi.parameter import OptionalIntParameter
15+
from luigi.parameter import OptionalPathParameter
16+
from luigi.parameter import OptionalStrParameter
1417
from luigi.task import flatten as task_flatten
1518
from luigi_tools.parameter import BoolParameter
1619
from luigi_tools.parameter import OptionalBoolParameter
17-
from luigi_tools.parameter import OptionalIntParameter
18-
from luigi_tools.parameter import OptionalPathParameter
19-
from luigi_tools.parameter import OptionalStrParameter
20-
from luigi_tools.task import CheckUnconsumedParamsMixin
2120
from luigi_tools.task import LogTargetMixin
2221
from luigi_tools.task import RerunMixin
2322
from numpy import VisibleDeprecationWarning
@@ -122,7 +121,6 @@ def __init__(self, col_mapping, **kwargs):
122121

123122

124123
class BaseValidationTask(
125-
CheckUnconsumedParamsMixin,
126124
LogTargetMixin,
127125
RerunMixin,
128126
TagResultOutputMixin,

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
README = f.read()
88

99
reqs = [
10-
"luigi",
10+
"luigi>=3.1",
1111
"luigi-tools>=0.0.18",
1212
"pandas",
1313
"rst2pdf",

tests/test_task.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import pause
2020
import pytest
2121
from diff_pdf_visually import pdfdiff
22-
from luigi_tools.parameter import OptionalStrParameter
22+
from luigi.parameter import OptionalStrParameter
2323

2424
from data_validation_framework import report
2525
from data_validation_framework import result

0 commit comments

Comments
 (0)