Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you need to change letter case, how now to output fields by their original names? #49

Open
scion4581 opened this issue Aug 2, 2024 · 3 comments
Labels

Comments

@scion4581
Copy link

https://github.com/BlueM/Tree/blob/ded69515db52cb95afd9655d632bfffc6494641c/src/Tree/Node.php#L40C9-L40C76

@scion4581 scion4581 changed the title Why do you need change letter case, how now to output fields by their original names? Why do you need to change letter case, how now to output fields by their original names? Aug 2, 2024
@BlueM
Copy link
Owner

BlueM commented Aug 2, 2024

This was a deliberate decision (quite some time ago) with the goal to make access via getters case-insensitive with minimal performance overhead. (See #32) Nowadays, I’d wouldn’t implement it like that anymore, and it’s very likely that this will change in the next major version.

@BlueM BlueM added the question label Aug 2, 2024
@TheDigitalOrchard
Copy link

TheDigitalOrchard commented Aug 13, 2024

@BlueM Are you teasing us with a "next major version" hint in there? Is there active development happening?

Will you accept pull requests from the community to help move this project forward? Then we could help address suggestions like mentioned here.

@BlueM
Copy link
Owner

BlueM commented Aug 25, 2024

@TheDigitalOrchard: there hadn’t been active development for a long time, but as it became increasingly obvious the code could need some modernizations, I’ve started working on some improvements recently. Among other things, in my local Git repo, the properties are no longer normalized to lowercase.

It’s very likely I will push the changes to a v4 branch, so anyone who is interested can experiment with it before a v4 is tagged, and potentially submit PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants