<Input required... WITH rendered output

[BrentH-Alnico]

Hi Boris,

I haphazardly discovered a minor issue:

I normally use required like this...
<input type="checkbox" value="{{:value}}" data-link="required{:value == 0}" />

But I forgot and used it like this...
<input type="checkbox" value="{{:value}}" data-link="required{:value == 1 ? true : false}" />
or this
<input type="checkbox" value="{{:value}}" data-link="required{:value == 1 ? 'required' : ''}" />
neither of which works.

Testing: I changed required to disabled and it did work strangely...

I looked at the JsViews source code and added attr === "required" to line 4797
else if (attr === "selected" || attr === "disabled" || attr === "multiple" || attr === "readonly" || attr === "required")

This fixed it and makes it consistent with how disabled works too ;-)

Brent

[BorisMoore]

Thanks Brent - I agree, that fix is appropriate.

I tested the following:

{^{on ~flipInteger/}} {^{:integer}} <br/>

<input type="checkbox" data-link="bool"> FlipBool {^{:bool}}<br/><br/>

<form>

  <button type="submit">Submit Changes</button><br/><br/>

  Requires fix
  <input type="checkbox" value="{{:value}}" data-link="required{:integer ? 'required' : ''}" /> 

  Requires fix
  <input type="checkbox" value="{{:value}}" data-link="required{:integer}" /> 

  Requires fix
  <input type="checkbox" value="{{:value}}" data-link="required{:bool == true ? 'required' : ''}" /> 

  Requires fix
  <input type="checkbox" value="{{:value}}" data-link="required{:bool ? 'required' : ''}" /> 

  Works without fix
  <input type="checkbox" value="{{:value}}" data-link="required{:integer==1}" />

  Works without fix
  <input type="checkbox" value="{{:value}}" data-link="required{:bool}" />

  Works without fix
  <input type="checkbox" value="{{:value}}" data-link="required{:bool == true}" />

</form>

With this code:

var tmpl = $.templates("#personTmpl");

var person = {
  integer: 0,
  bool: false
};

var helpers = {
  flipInteger: function() {
    $.observable(person).setProperty("integer", person.integer == 1 ? 0 : 1);
  }
}

tmpl.link("#result", person, helpers);

That said, I'm not sure whether to publish a new update based on this issue alone. We can see if any future issues come up that we want to publish fixes for (that we might then combine with this one).

But it's great that you identified this issue and associated fix...!

[BrentH-Alnico]

Yeah, it is so minor...I would wait. Thanks

[BorisMoore]

Hi Brent, I wanted to send you an email with some thoughts about JsViews that are not related to a specific GitHub repository issue. But I don't think I have your personal (private) email. Could you send it to me? You can email me directly at [email protected]. (I wanted to have a private conversation, not a public one on GitHub). Thanks! Best regards, Boris

…

On Mon, Oct 28, 2024 at 8:12 AM BrentH ***@***.***> wrote: Yeah, it is so minor...I would wait. Thanks — Reply to this email directly, view it on GitHub <#461 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRPIXI5VQBIDGJCOJQ43TZ5ZH4JAVCNFSM6AAAAABP2OBCSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRHA3DOMZYGQ> . You are receiving this because you commented.Message ID: ***@***.***>