Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for amount == 0 on deposit and withdraw in ButteredBread #114

Open
lirona opened this issue Dec 18, 2024 · 0 comments
Open

check for amount == 0 on deposit and withdraw in ButteredBread #114

lirona opened this issue Dec 18, 2024 · 0 comments
Assignees
@lirona

Comments

@lirona
Copy link
Contributor

lirona commented Dec 18, 2024

best practice to check, since these perform other functionalities (_syncDelegation and _syncVotingWeight)
lirona added a commit to lirona/breadchain that referenced this issue Dec 19, 2024
@lirona
add amount 0 checks (issue BreadchainCoop#114)
f382c7f
@lirona lirona mentioned this issue Dec 23, 2024
Merged
RonTuretzky pushed a commit that referenced this issue Dec 27, 2024
@lirona
liron's ButteredBread fixes (#120)
59eeba7 
* add amount 0 checks (issue #114)

* check transfer return value (issue #115)

* move transfer to the end of _deposit (issue #116)

also moved `_syncDelegation` just for consistency

* fix natspec for balanceOfLP (issue #118)

* _syncVotingWeight in deposit (issue #119)

* add warning to modifyAllowList (issue #117)

* custom errors

* add comment about ButteredBread changes

* revert move transferFrom

* add reentrancy guard on deposit

also added __ERC20Votes_init which does nothing but might change in future versions

* add nonReentrant on withdraw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lirona lirona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lirona