function balanceOfLP returns LPData and not balance in ButteredBread

[lirona]

the function name and natspec say it returns the balance but it returns LPData which contains balance and scaling factor.
there is another getter called accountToLPBalance which returns the balance.
consider removing this function if only the balance is needed, or changing it's name. for now i'll change the natspec at least :)

[RonTuretzky]

@secbajor @subject026 do you know the balanceOfLP is used in the crowdstaking app?

[subject026]

Not right now

[RonTuretzky]

Not right now

Is it planned in any way? Otherwise we might rename it

[subject026]

We will need to be able to fetch the scaling factors although I think being able to fetch them on their own rather than paired with a LP balance would be more flexible

[RonTuretzky]

We will need to be able to fetch the scaling factors although I think being able to fetch them on their own rather than paired with a LP balance would be more flexible

Yea we have another method that exposes it per lp. Great so we can remove this method I think @lirona ! Unless it's used in tests somewhere 🤔

[lirona]

hmm i don't see a getter for scaling factors per user anywhere.. @subject026 did you mean you need them per user and lp or just per lp?

[RonTuretzky]

I believe there's no reason we would need the modifier on the frontend at all, as there's another method that exposes the voting power and the modifier is accounted for in there