Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Modifiers #10

Open
daopunk opened this issue Jan 19, 2025 · 0 comments
Open

Use Modifiers #10

daopunk opened this issue Jan 19, 2025 · 0 comments
Assignees
@bagelface
Labels
good first issue Good for newcomers nice to have

Comments

@daopunk
Copy link
Collaborator

daopunk commented Jan 19, 2025 •
edited
Loading

this check is used 5 times, can be a modifier to clean up logic, reduce lines of code, and add more readability:
if (_isDecommissioned(_circle)) revert NotCommissioned();

same here
if (!isMember[_id][_member]) revert NotMember();
@daopunk daopunk changed the title Use Modifier Use Modifiers Jan 19, 2025
exo404 added a commit to exo404/saving-circles that referenced this issue Jan 28, 2025
@exo404
refactor : added modifiers to SavingCricles contract (issue Breadchai…
642877e 
…nCoop#10)
exo404 added a commit to exo404/saving-circles that referenced this issue Jan 28, 2025
@exo404
fix: syntax errors in SavingCircles contact (issue BreadchainCoop#10)
fa841b4
exo404 added a commit to exo404/saving-circles that referenced this issue Jan 28, 2025
@exo404
fix: error message modifiers (issue BreadchainCoop#10)
fd3fd92
exo404 added a commit to exo404/saving-circles that referenced this issue Jan 28, 2025
@exo404
fix: modifier not usable in "decomission" function to do if statement…
7289a6c 
… (issue BreadchainCoop#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagelface bagelface

Labels
good first issue Good for newcomers nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daopunk @RonTuretzky @bagelface