Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBSD: please update to libc 0.2.170 #137

Closed
0-wiz-0 opened this issue Feb 23, 2025 · 2 comments
Closed

NetBSD: please update to libc 0.2.170 #137

0-wiz-0 opened this issue Feb 23, 2025 · 2 comments
Labels
question Further information is requested

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Feb 23, 2025

There was a bug in the NetBSD implementation for getmntinfo in the libc crate which has been fixed and a new version of libc is released. This broke deleting files on file systems except /, since trash-rs didn't properly recognize that it was not on the same file system, and trashing to a different file system is not supported.

Please bump Cargo.toml so libc 0.2.170 is pulled in, and make a new release, so that I can propagate this fix to applications.

Thank you!

@Byron
Copy link
Owner

Byron commented Feb 23, 2025

Thanks for sharing!

When building an application, the application would be the one keep this dependency uptodate, right?
Setting the minimum version here would force all consumers to update, which is something that they might not need, for instance, if their application doesn't run on NetBSD.

@Byron Byron added the question Further information is requested label Feb 23, 2025
@0-wiz-0
Copy link
Author

0-wiz-0 commented Feb 23, 2025

That's true. (Though I wonder what you see as downsides of requiring a new libc.)
Sorry, I had forgotten that library crates usually don't provide a Cargo.lock file.
I'll directly go to the application. Thanks for the quick feedback!

@0-wiz-0 0-wiz-0 closed this as completed Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants