Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different calculation for latent heat upper limit for ground water #561

Open
ccarouge opened this issue Mar 6, 2025 · 1 comment
Open
Assignees
Labels
GWH Ground water hydrology integration work

Comments

@ccarouge
Copy link
Member

ccarouge commented Mar 6, 2025

In the latent heat code, we calculate an upper limit using:

fupper_limit(j) = REAL(ssnow_wb(j)-ssnow_wbice(j)/frozen_limit)*frescale(j)

Because the ground water uses a different calculation for wb, we need to introduce a specific case for the gw_model modifying the upper line to:

     fupper_limit(j) = REAL(ssnow_wb(j)-ssnow_wbice(j)*den_rat/frozen_limit)*frescale(j)

Note: the difference in the calculation of wb and wbliq in the ground water is in question, so this issue should be paused while the question is investigated.

@ccarouge ccarouge added blocked Issue that requires other work to be done first GWH Ground water hydrology integration work labels Mar 6, 2025
@ccarouge
Copy link
Member Author

following the discussion in #558 , it is confirmed we will need to introduce a separate calculation for fupper_limit for GW and non-GW. It's probably best to introduce a ice_volume that is either wbice or wbice*den_rat and keep a single form of the fupper_limit calculation. This issue is then unblocked and can be implemented.

It is not sure if the frozen_limit should change in consequence to the change to the meaning of wb in GW. The only thing we can do is add a warning for the doc.

We also need to update the doc on the calculation of fupper_limit as the warning is outdated.

@ccarouge ccarouge removed the blocked Issue that requires other work to be done first label Mar 26, 2025
@ccarouge ccarouge self-assigned this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GWH Ground water hydrology integration work
Projects
None yet
Development

No branches or pull requests

1 participant