Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone Viewer prod launcher #155

Open
mikemitchel opened this issue Oct 20, 2021 · 2 comments
Open

Standalone Viewer prod launcher #155

mikemitchel opened this issue Oct 20, 2021 · 2 comments
Assignees
@janebitovi
Labels
bug tech debt

Comments

@mikemitchel
Copy link
Contributor

On a deploy for the standalone viewer, the production index.html is not launching the app. Possible culprit is that it needs to use steal-sans-promises.production.js as the dev edition uses steal-sans-promises.js. While looking at this bug, we should review the difference between deploying the standalone viewer via a clone of this repo vs deploying from the zipped up build we currently set as the way of self hosters to deploy the viewer. It's possible that self hosters are using the 'dev' unminified version of the viewer and losing some performance there.
@mikemitchel
Copy link
Contributor Author

mikemitchel commented Oct 20, 2021 •
edited
Loading

stealjs/steal-tools#672 <--- steal-sans-promises.production.js
might also be worth upgrading to stealjs 2.x while fixing this issue

@tobiasnteireho
Copy link
Contributor

it looks like the dev launcher is broken too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janebitovi janebitovi

Labels
bug tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikemitchel @tobiasnteireho @janebitovi