Merge pull request #958 from CDLUC3/feature/950/JS-remove-page-scroll-from-template-create

Just removed scrollToTop on Template Create page

Author: jupiter007

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Fixed
 
 ### Removed
+- Removed `scrollToTop` from `Template Create` page [#950]
 
 ### Chore
 ====================================================================================================================================

components/SelectExistingTemplate/index.tsx

@@ -32,8 +32,6 @@ import {
   VersionedTemplateSearchResult,
 } from '@/generated/graphql';
 
-// Hooks
-import { useScrollToTop } from '@/hooks/scrollToTop';
 // Other
 import { logECS, routePath } from '@/utils/index';
 import {
@@ -63,7 +61,6 @@ const TemplateSelectTemplatePage = ({ templateName }: { templateName: string })
   const topRef = useRef<HTMLDivElement>(null);
   const formatDate = useFormatDate();
   const router = useRouter();
-  const { scrollToTop } = useScrollToTop();
   const toastState = useToast();
 
   // State
@@ -165,7 +162,6 @@ const TemplateSelectTemplatePage = ({ templateName }: { templateName: string })
   const resetSearch = () => {
     setSearchTerm('');
     handleSearchInput('');
-    scrollToTop(topRef);
   }
 
 

generated/graphql.tsx

@@ -1869,6 +1869,12 @@ export type PlanFeedbackErrors = {
   summaryText?: Maybe<Scalars['String']['output']>;
 };
 
+export enum PlanFeedbackStatusEnum {
+  Completed = 'COMPLETED',
+  None = 'NONE',
+  Requested = 'REQUESTED'
+}
+
 /** Funding associated with a plan */
 export type PlanFunding = {
   __typename?: 'PlanFunding';
@@ -2490,6 +2496,8 @@ export type Query = {
   planFeedback?: Maybe<Array<Maybe<PlanFeedback>>>;
   /** Get all of the comments associated with the round of admin feedback */
   planFeedbackComments?: Maybe<Array<Maybe<PlanFeedbackComment>>>;
+  /** Get the feedback status for a plan (NONE, REQUESTED, COMPLETED) */
+  planFeedbackStatus?: Maybe<PlanFeedbackStatusEnum>;
   /** Get all of the Funding information for the specific Plan */
   planFundings?: Maybe<Array<Maybe<PlanFunding>>>;
   /** Get all of the Users that are Members for the specific Plan */
@@ -2686,6 +2694,11 @@ export type QueryPlanFeedbackCommentsArgs = {
 };
 
 
+export type QueryPlanFeedbackStatusArgs = {
+  planId: Scalars['Int']['input'];
+};
+
+
 export type QueryPlanFundingsArgs = {
   planId: Scalars['Int']['input'];
 };