Skip to content

Commit 6248c0d

Browse files
committed
Fix circular import in serializers
Move imports to module level in segment and segment_financial_info serializers to avoid circular import issues.
1 parent 9f2f7ca commit 6248c0d

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

cesnet_service_path_plugin/api/serializers/segment.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
from netbox.api.serializers import NetBoxModelSerializer
1111
from rest_framework import serializers
1212

13+
from cesnet_service_path_plugin.api.serializers.segment_financial_info import (
14+
SegmentFinancialInfoSerializer,
15+
)
1316
from cesnet_service_path_plugin.models.segment import Segment
1417
from cesnet_service_path_plugin.utils import (
1518
determine_file_format_from_extension,
@@ -93,9 +96,6 @@ def get_financial_info(self, obj):
9396
request = self.context.get("request")
9497
if not request:
9598
return None
96-
from cesnet_service_path_plugin.api.serializers.segment_financial_info import (
97-
SegmentFinancialInfoSerializer,
98-
)
9999

100100
# Check if user has permission to view financial info
101101
has_financial_view_perm = request.user.has_perm("cesnet_service_path_plugin.view_segmentfinancialinfo")

cesnet_service_path_plugin/api/serializers/segment_financial_info.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# cesnet_service_path_plugin/api/serializers/segment_financial_info.py
2-
from rest_framework import serializers
32
from netbox.api.serializers import NetBoxModelSerializer
3+
from rest_framework import serializers
44

5-
from cesnet_service_path_plugin.models import SegmentFinancialInfo
5+
from cesnet_service_path_plugin.models import Segment, SegmentFinancialInfo
66

77

88
class SegmentPrimaryKeyRelatedField(serializers.PrimaryKeyRelatedField):
@@ -11,8 +11,6 @@ class SegmentPrimaryKeyRelatedField(serializers.PrimaryKeyRelatedField):
1111
"""
1212

1313
def get_queryset(self):
14-
from cesnet_service_path_plugin.models import Segment
15-
1614
return Segment.objects.all()
1715

1816

0 commit comments

Comments
 (0)