Disambiguate offset_polygon_2() from create_offset_polygons_2()

[afabri]

The first function is in 2D Minkowski Sums, the second function in Straight Skeletons.

We suggest to replace the latter by straight_skeleton_offset_polygons_2()

We stick to plural as it does not generate a single polygon with holes.
We drop the prefix create_ as that is what functions do.

[sgiraudot]

As no one complained in a year, I think we can assume this change can be made.

@afabri Can you take care of this?

[efifogel]

Look at the entire set of functions that this package provide.

---

/_____/) o /_________ __ //
(____ ( ( ( (/ (/-(-'_(/
_/

On Mon, Sep 28, 2015 at 5:30 PM, Andreas Fabri notifications@github.com
wrote:

The first function is in 2D Minkowski Sums, the second function in
Straight Skeletons.

We suggest to replace the latter by straight_skeleton_offset_polygons_2()

We stick to plural as it does not generate a single polygon with holes.
We drop the prefix create_ as that is what functions do.

—
Reply to this email directly or view it on GitHub
#371.

[sgiraudot]

Good point, it seems that both packages have their own name standards and we can't change one single function without changing the entire sets of function of one or the other packages (which seems an overkill to me).

Unless we can figure out a way of disambiguating these two functions without breaking the consistency of packages, I will close this issue.

[sgiraudot]

As no one suggested a better solution, I am closing this issue. Please open a small feature if you want to change the API.

[HoffmannMichael]

It is still an issue and it is unresolved. So I don’t see what is gained by closing it.

On 28 Oct 2016, at 07:58, Simon Giraudot <notifications@github.commailto:notifications@github.com> wrote:

As no one suggested a better solution, I am closing this issue. Please open a small feature if you want to change the API.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/371#issuecomment-256842654, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKyZmvKT1aplLViCXXqLV8pGYnCSVYiRks5q4Y8WgaJpZM4GE9ER.

[sgiraudot]

Alright, I'm reopening the issue but I don't see what is gained either by leaving an issue opened and not doing anything to solve it: this issue has been opened for a year with barely anyone participating. So far, the only proposition was from @afabri:

We suggest to replace the latter by straight_skeleton_offset_polygons_2()

Which is, as @efifogel pointed, not a valid solution as it breaks the consistency within the Straight Skeleton package. In my opinion, the fact that this is an issue is debatable, both packages have their own name standards and it seems unlikely that a user will mistake one from the other, but I'm not in the best position to judge.

@efifogel and @fcacciola, you are the respective maintainers of Straight_skeleton_2 and of Minkowski_sum_2: do you agree there is problem and if so, do you see any way we could solve it?