I found some missing keys

[faide]

I have written a small script to compare keys in betterkeys ng and yours and found some keys, that are necessary for quests, present in betterkeys ng (I am the maintainer) that you dont have in your mod... Here is the transcript of a run:

key from betterkeys not found in ett: 5448ba0b4bdc2d02308b456c
key from betterkeys not found in ett: 5913915886f774123603c392
key from betterkeys not found in ett: 664d4b0103ef2c61246afb56
key from betterkeys not found in ett: 66acd6702b17692df20144c0
key from betterkeys not found in ett: 658199aa38c79576a2569e13
key from betterkeys not found in ett: 5ad7247386f7747487619dc3
key from betterkeys not found in ett: 5a0448bc86f774736f14efa8
key from betterkeys not found in ett: 5a0ea79b86f7741d4a35298e
key from betterkeys not found in ett: 63a39f18c2d53c2c6839c1d3
key from betterkeys not found in ett: 63a39e1d234195315d4020bd
key from betterkeys not found in ett: 6398fd8ad3de3849057f5128
key from betterkeys not found in ett: 64ccc25f95763a1ae376e447
key from betterkeys not found in ett: 5c94bbff86f7747ee735c08f
key from betterkeys not found in ett: 5c1d0f4986f7744bb01837fa
key from betterkeys not found in ett: 5c1e2a1e86f77431ea0ea84c
key from betterkeys not found in ett: 5c1e2d1f86f77431e9280bee
key from betterkeys not found in ett: 591afe0186f77431bd616a11
key from betterkeys not found in ett: 5d08d21286f774736e7c94c3

I am willing to help if you want to.

[faide]

Added the quest info for each missing key:

key from betterkeys not found in ett: 5448ba0b4bdc2d02308b456c, for quest(s): ['5967530a86f77462ba22226b']
key from betterkeys not found in ett: 5913915886f774123603c392, for quest(s): ['59c9392986f7742f6923add2']
key from betterkeys not found in ett: 664d4b0103ef2c61246afb56, for quest(s): ['66058ccbc7f3584787181478', '66058cd19f59e625462acc90', '66058ccf06ef1d50a60c1f48']
key from betterkeys not found in ett: 66acd6702b17692df20144c0, for quest(s): ['669fa3a08b4a64b332041ff7']
key from betterkeys not found in ett: 658199aa38c79576a2569e13, for quest(s): ['657315e4a6af4ab4b50f3459']
key from betterkeys not found in ett: 5ad7247386f7747487619dc3, for quest(s): ['5ae449d986f774453a54a7e1']
key from betterkeys not found in ett: 5a0448bc86f774736f14efa8, for quest(s): ['5a0449d586f77474e66227b7']
key from betterkeys not found in ett: 5a0ea79b86f7741d4a35298e, for quest(s): ['5a27bc6986f7741c7358402b']
key from betterkeys not found in ett: 63a39f18c2d53c2c6839c1d3, for quest(s): ['639dbaf17c898a131e1cffff']
key from betterkeys not found in ett: 63a39e1d234195315d4020bd, for quest(s): ['639135a7e705511c8a4a1b78', '639135bbc115f907b14700a6', '6396700fea19ac7ed845db32']
key from betterkeys not found in ett: 6398fd8ad3de3849057f5128, for quest(s): ['63966fbeea19ac7ed845db2e']
key from betterkeys not found in ett: 64ccc25f95763a1ae376e447, for quest(s): ['64ee99639878a0569d6ec8c9']
key from betterkeys not found in ett: 5c94bbff86f7747ee735c08f, for quest(s): ['5d25e4b786f77408251c4bfc', '5edac34d0bb72a50635c2bfa']
key from betterkeys not found in ett: 5c1d0f4986f7744bb01837fa, for quest(s): ['639670029113f06a7c3b2377']
key from betterkeys not found in ett: 5c1e2a1e86f77431ea0ea84c, for quest(s): ['639670029113f06a7c3b2377']
key from betterkeys not found in ett: 5c1e2d1f86f77431e9280bee, for quest(s): ['639670029113f06a7c3b2377']
key from betterkeys not found in ett: 591afe0186f77431bd616a11, for quest(s): ['59c9392986f7742f6923add2', '59675d6c86f7740a842fc482']
key from betterkeys not found in ett: 5d08d21286f774736e7c94c3, for quest(s): ['5d25e2ee86f77443e35162ea']

[robpneu]

Hi @faide! I appreciate you diving into this!

CJ has decided to step away from maintaining SPT mods for the time being. I've requested to take over maintenance of this mod and CJ has agreed. I'll be maintaining it at https://github.com/robpneu/SPT-Expanded-Task-Text.

The data from this mod comes from the tarkov.dev API. I went through the keys and quests you mentioned and I think I've figured out most of the discrepancies:

• Some were added in v1.6.3, so they were not in the version of the mod when you made this comment.
• Expanded Task Quest only looks at keys that are
  1. used to complete a quest objective (not just hand-over)
  2. are required (both the objectives needs to be required as well as the key being required to complete the objective)
• Data is missing from tarkov.dev API in a few cases (I've contacted the tarkov.dev team).

Here's the specifics:

key from betterkeys not found in ett: 5448ba0b4bdc2d02308b456c, for quest(s): ['5967530a86f77462ba22226b'] - optional objective
key from betterkeys not found in ett: 5913915886f774123603c392, for quest(s): ['59c9392986f7742f6923add2'] - handover
key from betterkeys not found in ett: 664d4b0103ef2c61246afb56, for quest(s): ['66058ccbc7f3584787181478', '66058cd19f59e625462acc90', '66058ccf06ef1d50a60c1f48'] - Quests are missing from tarkov.dev API
key from betterkeys not found in ett: 66acd6702b17692df20144c0, for quest(s): ['669fa3a08b4a64b332041ff7'] - added in v1.6.3
key from betterkeys not found in ett: 658199aa38c79576a2569e13, for quest(s): ['657315e4a6af4ab4b50f3459'] - listed as optional (you can get into the office without it by climbing on the windowsill from the adjacent office)
key from betterkeys not found in ett: 5ad7247386f7747487619dc3, for quest(s): ['5ae449d986f774453a54a7e1'] - handover
key from betterkeys not found in ett: 5a0448bc86f774736f14efa8, for quest(s): ['5a0449d586f77474e66227b7'] - handover
key from betterkeys not found in ett: 5a0ea79b86f7741d4a35298e, for quest(s): ['5a27bc6986f7741c7358402b'] - incorrect? I'm not seeing this key anywhere related to this quest.
key from betterkeys not found in ett: 63a39f18c2d53c2c6839c1d3, for quest(s): ['639dbaf17c898a131e1cffff'] - room is always unlocked, so the key is not required
key from betterkeys not found in ett: 63a39e1d234195315d4020bd, for quest(s): ['639135a7e705511c8a4a1b78', '639135bbc115f907b14700a6', '6396700fea19ac7ed845db32'] - 6396700fea19ac7ed845db32 was added in v1.6.3. The others list this key as required on the wiki but with a caveat that the apartment 10 door can be breached so I don't think it's considered required
key from betterkeys not found in ett: 6398fd8ad3de3849057f5128, for quest(s): ['63966fbeea19ac7ed845db2e'] - added in v1.6.3
key from betterkeys not found in ett: 64ccc25f95763a1ae376e447, for quest(s): ['64ee99639878a0569d6ec8c9'] - tarkov.dev API does not list this as a required key, but the wiki does. I'm working with the tarkov.dev team to get this fixed.
key from betterkeys not found in ett: 5c94bbff86f7747ee735c08f, for quest(s): ['5d25e4b786f77408251c4bfc', '5edac34d0bb72a50635c2bfa'] - handover
key from betterkeys not found in ett: 5c1d0f4986f7744bb01837fa, for quest(s): ['639670029113f06a7c3b2377'] - added in v1.6.3
key from betterkeys not found in ett: 5c1e2a1e86f77431ea0ea84c, for quest(s): ['639670029113f06a7c3b2377'] - listed in the wiki as not technically required because not all spawn locations for the quest item require the key
key from betterkeys not found in ett: 5c1e2d1f86f77431e9280bee, for quest(s): ['639670029113f06a7c3b2377'] - added in v1.6.3
key from betterkeys not found in ett: 591afe0186f77431bd616a11, for quest(s): ['59c9392986f7742f6923add2', '59675d6c86f7740a842fc482'] - handover for 59c9392986f7742f6923add2 and optional for 59c9392986f7742f6923add2
key from betterkeys not found in ett: 5d08d21286f774736e7c94c3, for quest(s): ['5d25e2ee86f77443e35162ea'] - handover

Out of curiosity, what are you using for your data source?
If you find any others, please let me know!