Skip to content

Conversation

@exaexa
Copy link
Member

@exaexa exaexa commented Feb 27, 2025

No description provided.

if this had a function, it should have been commented.
@exaexa exaexa requested review from HettieC and stelmo February 27, 2025 09:44
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b755e4e) to head (1688a4c).

Additional details and impacted files
@@              Coverage Diff               @@
##           mk-ident-map       #31   +/-   ##
==============================================
  Coverage        100.00%   100.00%           
==============================================
  Files                 6         6           
  Lines               297       297           
==============================================
  Hits                297       297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa
Copy link
Member Author

exaexa commented Feb 27, 2025

@HettieC re #23 this should basically allow you to just do using AbstractFBCModels and have all function names right in the namespace, yolo way. I guess it does the trick. Old way of doing the import carefully and slowly stays there.

@exaexa exaexa merged commit 3b56808 into mk-ident-map Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants