-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponsorship Page #29
base: main
Are you sure you want to change the base?
Sponsorship Page #29
Conversation
925d8c2
to
29decc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有些建議可能不只一個檔案,所以就這邊提一下:
- 或許減少或盡量避免 inline style
- renderMarkdown 基本給 marked 一樣,可以直接使用 marked
- 可能要注意一下暗黑模式下的畫面
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
暗黑模式下,顏色看起來不太 ok
components/SponsorshipFAQs.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
暗黑模式下,顏色看起來不太 ok
components/SponsorshipTable.vue
Outdated
'議程頁面廣告(按等級比重播出)', | ||
], | ||
'活動現場:(與 COSCUP 聯名)': [ | ||
'會場迎賓牆曝光', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這些 array 的部分,都可以盡量用 markdown 表示
components/SponsorshipTable.vue
Outdated
return marked(text) | ||
} | ||
|
||
function handlePrint() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我在想是不是這個 method 另外寫啊(?
在思考與討論看看
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我在想 components/SponsorshipAddonsTable.vue
和 components/SponsorshipTable.vue
的 function handlePrint() 是不是要提出來共用?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這裡呼叫其他人來討論看看 @rileychh
晚上來看看😁
目前做了以下調整:
然後,我的 Code Quality Checks 一直過不了 😭 |
因為原本的 script 沒有標記 ts,所以 code quality checks 沒有檢查, |
afe5427
to
de9f954
Compare
抱歉我沒有說清楚,造成 type check 錯誤的問題是因為 lang='ts',但是是需要加上的,所以我把他改回來,然後修了這個問題。 |
然後順手把上次討論的結構 rebase 進來 |
de9f954
to
43e4f68
Compare
這邊有個想法,或許可以參考一些網站的定價頁面來重新設計贊助階級頁面,讓資訊更清楚,避免重複描述。 舉例來說,ChatGPT 的定價頁面 的設計就可以作為參考:
雖然目前的設計將最高階級放在最前面,可能會讓贊助者更傾向於選擇高階級方案,但從整體資訊的易讀性來看,依照階級順序排列會更直觀。 |
順帶一提,我發現可以把 Markdown 當作 Vue SFC 一樣匯入到其他 Markdown。
**官網 及 OPass app:**
- 公司簡介
- 議程頁面廣告(按等級比重播出)
<!-- ... -->
<script setup lang="ts">
import TitaniumBenefits from './TitaniumBenefits.md'
</script>
# 贊助
## 贊助方案
| 贊助等級 | 贊助金額 | 贊助福利 |
| -------- | ----------- | -------------------- |
| 鈦金級 | NT$ 238,000 | <TitaniumBenefits /> | 這樣就不需要使用 |
This reverts commit cfb9140.
43e4f68
to
33ea707
Compare
No description provided.