Skip to content

inline_constant_functions pass produces invalid Hugrs #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mark-koch opened this issue Apr 29, 2025 · 0 comments · May be fixed by #2135
Open

inline_constant_functions pass produces invalid Hugrs #2132

mark-koch opened this issue Apr 29, 2025 · 0 comments · May be fixed by #2135
Assignees
@mark-koch
Labels
bug Something isn't working llvm Pertains to LLVM emission

Comments

@mark-koch
Copy link
Contributor

mark-koch commented Apr 29, 2025 •
edited
Loading

Looks like the function definitions created by this pass contain the whole DFG node instead of inlining the graph. This results in an InvalidInitialChild error

Also, the generated LoadFunction nodes have an unconnected input
@mark-koch mark-koch added bug Something isn't working llvm Pertains to LLVM emission labels Apr 29, 2025
@mark-koch mark-koch self-assigned this Apr 29, 2025
@mark-koch mark-koch linked a pull request Apr 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
bug Something isn't working llvm Pertains to LLVM emission
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix inline_constant_functions pass CQCL/hugr
1 participant
@mark-koch