Update Bomber Icon shortcode usage

[jnschrag]

Currently, the site is set up to include the Bomber Icon automatically at the end of the post content unless the program has checked a meta box that says to not include it. The new Gutenberg blocks mean that including the icon will result in it being separated on its own line below the content as opposed to on the same line as the last bit of text content.

To fix this, we need to rework this feature so that the program must manually include the Bomber shortcode when they want to use it.

To-dos

• Remove filter on the_content. Relevant function here.
• Remove custom post meta box for _post_disable_post_bottom_icon on all relevant post types
• Look at possibility of adding a button to the toolbar to insert the [aircraft] shortcode when clicked. Check-out this tutorial from the documentation.

[dlousa92]

An update on this issue, I just created a pull request for the first two checkboxes, below is an update on the last checkbox

I'm able to add a button into the toolbar using the format API so that's awesome! Screenshot below,

However the biggest hurdle I'm having right now is how to add the shortcode into that button. There's a few methods in rich-text that are possible to use, linked here. I've been experimenting with applyFormat and toggleFormat. These do work in the sense that I'm able to insert code that's similar to the shortcode as per the screenshot below,

The main problem is I'm unable to set an src link to the image using these methods. I can set a background url for this element with the bomber image in css, however I know that's kind of hacky.

Another possible solution I've found is that perhaps it's possible to create a Gutenberg block that would be the bomber icon and then making this block inline with css. Here is a link to an issue on the gutenberg repository that references this.