cveRecordSearchModule: add allValidCharacters(); SearchResults: remove non-production warning about test data (incorrect)

Author: rlxdev

src/components/cveRecordSearchModule.vue

@@ -144,7 +144,7 @@ function startSearch() {
   if (cveGenericGlobalsStore.useSearch) {
       cveListSearchStore.$reset();
       cveListSearchStore.query = queryString.value;
-      if (route?.name !== 'SearchResults' || !route.query?.query
+      if (route.name !== 'SearchResults' || !route.query?.query
           || (route.query.query !== cveListSearchStore.query)) {
 
         router.push({name: 'SearchResults',
@@ -233,8 +233,10 @@ function normalizeSearchString() {
 }
 
 function onInputChange() {
+
   // This function is called when the search string changes.  The only purpose
-  // is to clear the way for the search if there's a value (it's not empty)
+  // is to clear the way for the search if there's a value (it's not empty),
+  // it doesn't contain any characters not supported by the search,
   // and it's not the same as a "bad" value used in the previous search.
   // As long as this is the case, we enable the search, which will then check
   // the validity of the search string when initiated.
@@ -252,8 +254,12 @@ function onInputChange() {
     errorMessageStore.$reset();
     cveListSearchStore.isSearchButtonDisabled = true;
 
-  } else if (cveListSearchStore.isSearchButtonDisabled
+  } else if (!allValidCharacters(searchValue)) {
+    cveListSearchStore.isSearchButtonDisabled = true;
+  }
+  else if (cveListSearchStore.isSearchButtonDisabled
              && prevSearchValue.value !== searchValue) {
+    errorMessageStore.$reset();
     cveListSearchStore.isSearchButtonDisabled = false;
   }
 }
@@ -289,6 +295,29 @@ function validate() {
   }
 }
 
+function allValidCharacters(searchString) {
+
+  // This function checks the given search string for the presence of
+  // any characters that are not supported for the search operation.
+  // True is returned if the string has no invalid characters, and false
+  // otherwise.  The error message is also set to indicate the invalid
+  // characters found in the string.
+  //
+  // Leave out the asterisk (*) for the moment, just for testing purposes:
+  const invalidCharacters = '{}[]"\'`<>+=|\;!~^'.split('');
+
+  const found = invalidCharacters.filter(i => searchString.includes(i));
+
+  if (found.length) {
+    const message = 'search string contains the following invalid '
+      + `character(s): ${found.join('')}`;
+
+    errorMessageStore.setErrorMessage(message);
+  }
+
+  return found.length === 0;
+}
+
 function resetSearch() {
 
   // This function performs some reset tasks for the search that are
@@ -297,7 +326,7 @@ function resetSearch() {
 
   prevSearchValue.value = '';
 
-  if (route?.name != 'home' || route?.query)
+  if (route.name != 'home' || route.query)
     router.push({name: 'home', query: {}});
 }
 </script>

src/views/CVERecord/SearchResults.vue

@@ -26,17 +26,6 @@
                   <ServiceUnavailable></ServiceUnavailable>
                 </div>
                 <div v-else>
-                  <div v-if="!genericGlobalsStore.isProductionWebsite"
-                    class="notification is-warning is-light" role="alert">
-                    <div class="is-flex is-justify-content-center">
-                      <p id="alertIconCveRecordsRequestErrored" class="is-hidden">alert</p>
-                      <font-awesome-icon style="flex: 0 0 40px;" size="1x"  icon="triangle-exclamation" role="alert"
-                        aria-labelledby="alertIconCveRecordsRequestErrored" aria-hidden="false" />
-                      <p>You are accessing data from
-                        {{ generalGlobalsStore.currentServicesUrl }}
-                      </p>
-                    </div>
-                  </div>
                   <h2 class="title">Search Results</h2>
                   <div class="mb-3" v-if="hasRecordData || hasIdData">
                     <h3 class="title is-size-5 mb-2"> CVE {{ getRecordOrIdLabel }} Found</h3>