-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oceano app: "no observations were found"; + log all queries w/ response stats; + Shiny bookmark query state #24
Comments
Hi @evsatt , Sorry about the issue here, which I'm having trouble understanding and replicating. I see a contoured surface map, so not sure if it was for a different area or other setting not visible when you clicked Update. This points to the very real need to log all queries and basic stats on the response, but particularly for those queries which fail and need to be debugged. And ideally to also add a copy link button to return to the app in the same state (possible with Shiny Bookmarking). Here's what I was able to successfully generate: And some of the outputs from the bottom Downloads links: |
Yes please! I'll try to have this sorted by our meeting Wednesday |
Here is the error message:
[image: image.png]
Also, when I do get it to work with a different area, the year increments
are incorrect (e.g., for "year" should have whole years not halves too).
…On Wed, Nov 29, 2023 at 8:17 AM Ben Best ***@***.***> wrote:
Yes please! I'll try to have this sorted by our meeting Wednesday
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/CalCOFI/apps/issues/24*issuecomment-1832226443__;Iw!!Mih3wA!CKkSi5Kwce4LsF1K7ASMS4MfZVU_XSUVdBlSc5lUCfCccA-gt-DcITpexjarBntv-4ojw50X729Uq4_kQpCYCQifh4h67g$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AD356WLTK6AEFTV3W4XBBWDYG5N2FAVCNFSM6AAAAAA77WHPD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGIZDMNBUGM__;!!Mih3wA!CKkSi5Kwce4LsF1K7ASMS4MfZVU_XSUVdBlSc5lUCfCccA-gt-DcITpexjarBntv-4ojw50X729Uq4_kQpCYCQiorejAaQ$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Erin Satterthwaite | she/her
Marine Ecologist & Sustainability Researcher
CalCOFI Program Coordinator
UC San Diego - Scripps Institution of Oceanography
California Sea Grant & CalCOFI
9500 Gilman Dr., La Jolla, CA 92093-0232
*work: *(858) 380-5835
*Play is the highest form of research *
* ~Albert Einstein*
|
Shiny Bookmarking in URLNow the URL in the browser's location bar gets updated as the user changes input values, so the URL can be shared to return to the same state. References:
Here are the URLs for two maps with entirely different inputs:
|
Logging with
|
# logger, loggit, | |
lubridate, plotly, png, readr, shiny, shinydashboard, shinyjs, | |
stringr, webshot) | |
# remotes::install_github("calcofi/calcofi4r", force=T) # install remote | |
# devtools::install_local(here::here("../calcofi4r"), force=T) # install local | |
# devtools::load_all(here("../calcofi4r")) # debug | |
# loggit::set_logfile("/share/github/apps_dev/oceano/logs/loggit.log") | |
# loggit::read_logs() | |
# logger::log_appender(appender_file("/share/github/apps_dev/oceano/logs/logger.log")) | |
# logger::log_appender() |
Lines 339 to 363 in 560187f
# log_info( | |
# list(get_map_data = list( | |
# variable = variable, | |
# value = value, | |
# aoi_ewkt = aoi_ewkt, | |
# aoi_keys = aoi_keys))) | |
# loggit( | |
# "INFO", | |
# "get_map_data()", | |
# data_json = jsonlite::toJSON(list( | |
# variable = variable, | |
# value = value, | |
# aoi_ewkt = aoi_ewkt, | |
# aoi_keys = aoi_keys, | |
# date_beg = date_beg, | |
# date_end = date_end, | |
# date_qrtr = date_qrtr, | |
# depth_m_min = depth_m_min, | |
# depth_m_max = depth_m_max, | |
# n_bins = n_bins, | |
# return_type = return_type, | |
# dir_cache = dir_cache, | |
# clientData = clientData)) |> | |
# as.character()) |
Skipping shinylogs
since logging excessive and not customizable.
Surprisingly the client's IP address is not included in Shiny's session$clientData
so can't easily include in log:
from @evsatt:
This points to the very real need to:
Log all queries and basic stats on the response, but particularly for those queries which fail and need to be debugged.
Also add a copy link button to return to the app to the same state (possible with Shiny Bookmarking).
The text was updated successfully, but these errors were encountered: