Skip to content

Commit d15b00a

Browse files
committed
Fix failed CI test
1 parent ca2e737 commit d15b00a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

ibis-server/app/model/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class MySqlConnectionInfo(BaseModel):
9595
database: SecretStr
9696
user: SecretStr
9797
password: SecretStr
98-
ssl_mode: SecretStr = Field(alias="sslMode")
98+
ssl_mode: SecretStr | None = Field(alias="sslMode", default=None)
9999
ssl_ca: SecretStr | None = Field(alias="sslCA", default=None)
100100
kwargs: dict[str, str] | None = Field(
101101
description="Additional keyword arguments to pass to PyMySQL", default=None

ibis-server/app/model/data_source.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,11 @@ def _escape_special_characters_for_odbc(value: str) -> str:
183183

184184
@staticmethod
185185
def _create_ssl_context(info: ConnectionInfo) -> Optional[ssl.SSLContext]:
186-
ssl_mode = info.ssl_mode.get_secret_value()
186+
ssl_mode = (
187+
info.ssl_mode.get_secret_value() if hasattr(info, "ssl_mode") else None
188+
)
187189

188-
if ssl_mode == SSLMode.DISABLE:
190+
if not ssl_mode or ssl_mode == SSLMode.DISABLE:
189191
return None
190192

191193
ctx = ssl.create_default_context()

0 commit comments

Comments
 (0)