From ab7c130befbf5cb1106726f80bd53382b01ae295 Mon Sep 17 00:00:00 2001 From: AshwinSri23 Date: Thu, 2 Jan 2025 14:01:19 -0500 Subject: [PATCH 1/2] Revert "Updated index.ts and issue_closed.ts" This reverts commit 5112e4138cea470b4fce7a68a16db838723d9a5d. --- src/index.ts | 4 ++-- src/lib/issue_closed.ts | 6 +----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/index.ts b/src/index.ts index 0d90632..2a50d33 100644 --- a/src/index.ts +++ b/src/index.ts @@ -6,7 +6,6 @@ import { appendInitialMetadata, createMilestone } from './lib/issue_opened'; import { createNextIssue, commentSummary } from './lib/issue_closed'; import { Issue } from './lib/types'; - /* Logger Configuration */ const logger = winston.createLogger({ level: 'debug', @@ -62,9 +61,10 @@ const app = (probotApp: Probot) => { // Create next issue const nextIssue = await createNextIssue(context, logger); if (!nextIssue) { - logger.error('createNextIssue: Next Issue is not set or the maximium issue has been reached'); + logger.error('createNextIssue: Next Issue is not set.'); return; } + // Comment Summary await commentSummary(context, logger, nextIssue); }); diff --git a/src/lib/issue_closed.ts b/src/lib/issue_closed.ts index 54503da..fb3e31a 100644 --- a/src/lib/issue_closed.ts +++ b/src/lib/issue_closed.ts @@ -17,10 +17,6 @@ export const createNextIssue = async (context: IssuesContext, logger: Logger): P } const stage = metadata.stage + 1; - if (stage > MAX_STAGE) { - logger.error('createNextIssue: Stage is already at maximum.'); - return null; - } const filePaths = await fg(`${MD_DIR}/${stage}-*/body.md`); if (filePaths.length === 0) { @@ -64,7 +60,7 @@ export const createNextIssue = async (context: IssuesContext, logger: Logger): P export const commentSummary = async ( context: IssuesContext, logger: Logger, - nextIssue: Issue + nextIssue: Issue, ): Promise => { const { owner, repo, issue } = await getContextProps(context); const metadata = extractMetadata(issue); From ae44c7ef798bc31872851d0e5331b1e4fb32b68e Mon Sep 17 00:00:00 2001 From: AshwinSri23 Date: Thu, 2 Jan 2025 14:02:25 -0500 Subject: [PATCH 2/2] Reapply "Updated index.ts and issue_closed.ts" This reverts commit ab7c130befbf5cb1106726f80bd53382b01ae295. --- src/index.ts | 4 ++-- src/lib/issue_closed.ts | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/index.ts b/src/index.ts index 2a50d33..0d90632 100644 --- a/src/index.ts +++ b/src/index.ts @@ -6,6 +6,7 @@ import { appendInitialMetadata, createMilestone } from './lib/issue_opened'; import { createNextIssue, commentSummary } from './lib/issue_closed'; import { Issue } from './lib/types'; + /* Logger Configuration */ const logger = winston.createLogger({ level: 'debug', @@ -61,10 +62,9 @@ const app = (probotApp: Probot) => { // Create next issue const nextIssue = await createNextIssue(context, logger); if (!nextIssue) { - logger.error('createNextIssue: Next Issue is not set.'); + logger.error('createNextIssue: Next Issue is not set or the maximium issue has been reached'); return; } - // Comment Summary await commentSummary(context, logger, nextIssue); }); diff --git a/src/lib/issue_closed.ts b/src/lib/issue_closed.ts index fb3e31a..54503da 100644 --- a/src/lib/issue_closed.ts +++ b/src/lib/issue_closed.ts @@ -17,6 +17,10 @@ export const createNextIssue = async (context: IssuesContext, logger: Logger): P } const stage = metadata.stage + 1; + if (stage > MAX_STAGE) { + logger.error('createNextIssue: Stage is already at maximum.'); + return null; + } const filePaths = await fg(`${MD_DIR}/${stage}-*/body.md`); if (filePaths.length === 0) { @@ -60,7 +64,7 @@ export const createNextIssue = async (context: IssuesContext, logger: Logger): P export const commentSummary = async ( context: IssuesContext, logger: Logger, - nextIssue: Issue, + nextIssue: Issue ): Promise => { const { owner, repo, issue } = await getContextProps(context); const metadata = extractMetadata(issue);