Rounding error when determining fee for Contract Transaction

[jimtendo]

[In ](

cashscript/packages/cashscript/src/Transaction.ts

Line 325 in 123e45a

fee = Math.ceil(fee);

) the following line can sometimes lead to an incorrect fee as it does a Math.ceil on the value.

This means that if JS's Math engine, for example, gave a result of something like 620.00000001 in the preceding math, the Math.ceil() would round this up to 621, causing an off-by-one error.

Math.round() will probably resolve this as, even with JS Math's inconsistencies, it should always round back to the correct target integer.

[mr-zwets]

Hi there! Following up on this old issue, this code got rewritten 20 months ago as part of 'Enforce bigint for all script numbers and bch amounts'

bac5967#diff-5a9bd0f77f6dbbec45a9d9e9d42a52174ebd6701d18d1434ebae2a302f1e866b

Now the fee calculation code looks like this:

// High precision may not work with some 'number' inputs, so we set the default to 6 "decimal places"
const addPrecision = (amount: number | bigint, precision: number = 6): bigint => {
  if (typeof amount === 'number') {
    return BigInt(Math.ceil(amount * 10 ** precision));
  }

  return amount * BigInt(10 ** precision);
};

so it still includes a Math.ceil() but only for the number type but this is likely still problematic due to addPrecision(contractInputSize * this.feePerByte);