Skip to content

Commit fa6c316

Browse files
IoanaCiorneixxb1995
authored andcommitted
dpaa2-eth: increase busy retries when interracting with QBMAN
It seems that there are circumstances when access to QBMAN through the software portals will be delayed. Accessing some lower speeds interfaces while also QBMAN commands are issued from the kernel will lead to software timeouts happening in the dpaa2-eth driver. What we have observed is that management commands like re-arming the interrupts on a specific channel, waiting for a dequeue response to be available etc, will take a longer time to complete. All these commands have to wait for a valid bit to be set for the command to be interpreted as successfully completed. Increase the maximum number of times the Linux kernel drivers will busy poll for a successful result of one of these commands. Signed-off-by: Ioana Ciornei <[email protected]>
1 parent ccd72ab commit fa6c316

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ static inline struct dpaa2_faead *dpaa2_get_faead(void *buf_addr, bool swa)
354354
* hardware becomes unresponsive, but not give up too easily if
355355
* the portal really is busy for valid reasons
356356
*/
357-
#define DPAA2_ETH_SWP_BUSY_RETRIES 1000
357+
#define DPAA2_ETH_SWP_BUSY_RETRIES 10000
358358

359359
/* Driver statistics, other than those in struct rtnl_link_stats64.
360360
* These are usually collected per-CPU and aggregated by ethtool.

drivers/soc/fsl/dpio/qbman-portal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ static inline int qbman_swp_CDAN_set_context_enable(struct qbman_swp *s,
543543
static inline void *qbman_swp_mc_complete(struct qbman_swp *swp, void *cmd,
544544
u8 cmd_verb)
545545
{
546-
int loopvar = 2000;
546+
int loopvar = 10000;
547547

548548
qbman_swp_mc_submit(swp, cmd, cmd_verb);
549549

0 commit comments

Comments
 (0)