Skip to content

React v16 still not supported? #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngbrown opened this issue Nov 3, 2017 · 3 comments
Closed

React v16 still not supported? #19

ngbrown opened this issue Nov 3, 2017 · 3 comments

Comments

@ngbrown
Copy link

ngbrown commented Nov 3, 2017

Based on the closed issue, #16, I thought React v16 was supported, but I just received the following exception when trying to start storybook after installing react-storybook-addon-chapters v2.0.0 from npm:

ERROR in ./node_modules/markdown-to-react-components/src/CodeComponent.js
Module not found: Error: Can't resolve 'create-react-class' in 'D:\dev\H-D\revival-tis\te-revival\node_modules\markdown-to-react-components\src'
 @ ./node_modules/markdown-to-react-components/src/CodeComponent.js 2:23-52
 @ ./node_modules/markdown-to-react-components/src/index.js
 @ ./node_modules/react-storybook-addon-chapters/dist/utils/info-content.js
 @ ./node_modules/react-storybook-addon-chapters/dist/components/Story.js
 @ ./node_modules/react-storybook-addon-chapters/dist/index.js
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/react/dist/server/config/polyfills.js ./node_modules/@storybook/react/dist/server/config/globals.js (webpack)-hot-middleware/client.js?reload=true ./.storybook/config.js

It appears that markdown-to-react-components hasn't been supporting React since 15.6.1 and Marksy is the replacement.

@storybook/react is v3.2.14.

@ngbrown
Copy link
Author

ngbrown commented Nov 3, 2017

Update: I can add create-react-class as a peer dependency, but that's not ideal since it's depreciated. Can the markdown component be switched to Marksy?

@brandonellis
Copy link
Contributor

brandonellis commented Nov 3, 2017

Yup, shouldn't have caused any install errors as the package.json is referencing a specific hash in the repo (which was still compatible). It's one of the last upgrades to swap over.

@brandonellis
Copy link
Contributor

@ngbrown Recent release should take care of your problems. Migrated to 'marksy' repo and fixed the markdown issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants