Fix CompoundVault strategy loss accounting#5129
Closed
xyjk0511 wants to merge 1 commit into
Closed
Conversation
CompoundVault compound accounting now uses before/after strategy balances so positive yield, zero yield, and negative returns update vault share price consistently while recording cumulative strategy loss. Constraint: OpenAgents issue ClankerNation#110 requires contributor metadata and tests without disclosing private platform instructions. Rejected: Treat reward balance as all-new yield | overcounts existing deposits and repeated compounds. Confidence: high Scope-risk: narrow Directive: Preserve delta-based accounting if future strategy adapters move funds through the vault balance. Tested: npx hardhat test --config .\.codex-compoundvault-hardhat.config.js test\CompoundVaultLoss.test.js; npx solcjs --bin --abi contracts\vault\CompoundVault.sol -o .codex-compoundvault-solc --base-path . --include-path node_modules; node --check test\CompoundVaultLoss.test.js; node --check .codex-compoundvault-hardhat.config.js; node -e JSON.parse CONTRIBUTORS.json; git diff --check Not-tested: npm test is blocked by existing HH606 compiler mismatch in YieldAggregator/GovernorAlpha dependencies requiring ^0.8.24 while hardhat.config.js uses 0.8.20.
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #110
💳 Payment: PayPal | buchanliang@gmail.com | PayPal
Summary
CompoundVault.compound()and compares vault reward-token balance before/after the strategy call.totalLosswhile loweringtotalDeposited/ share price proportionally.StrategyLoss(loss, newPricePerShare)for negative strategy returns.Verification
npx hardhat test --config .\.codex-compoundvault-hardhat.config.js test\CompoundVaultLoss.test.js-> 4 passingnpx solcjs --bin --abi contracts\vault\CompoundVault.sol -o .codex-compoundvault-solc --base-path . --include-path node_modules-> passednode --check test\CompoundVaultLoss.test.js-> passednode --check .codex-compoundvault-hardhat.config.js-> passednode -e "JSON.parse(require('fs').readFileSync('CONTRIBUTORS.json','utf8')); console.log('CONTRIBUTORS.json ok')"-> passedgit diff --check-> passedKnown baseline issue
npm testis still blocked by the repository's existing HH606 compiler mismatch:hardhat.config.jsconfigures Solidity 0.8.20 while current OpenZeppelin dependencies pulled bycontracts/vault/YieldAggregator.solandcontracts/governance/GovernorAlpha.solrequire^0.8.24.