pg_ctl calls are broken if pg_ctl needs any env variables

[dondelelcaro]

We do some (admittedly odd) things in a custom pg_ctl under our CI/CD environment (basically, becoming a non-root user) which require having $PATH be set, amongst other things. [pg_ctl is a shell script that makes some calls to pg_config before exec'ing the real pg_ctl, so it needs PATH working.]

The changes to fix 343 broke this approach because now the only environmental variables set are LANG and LC_ALL.

Making:

subprocess.check_output(init_directory, env=self._envvars)

subprocess.check_output(init_directory,env=dict(os.environ).update(self._envvars))

or equivalent should fix this.

[fizyk]

Okay, I've looked around and, let's say, the fix will be placed in Mirakuru itself 🤔

[fizyk]

dbfixtures/mirakuru#842