Skip to content

Commit c0da0ac

Browse files
authored
Merge pull request #127 from CodeGov-org/nathan/rename-rvm-proposal
feat: rename rvm proposal references
2 parents ae9e005 + 265e62d commit c0da0ac

37 files changed

+1341
-551
lines changed

README.md

Lines changed: 24 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,12 @@ To assign a user as an admin, run the following command:
288288
dfx canister call backend update_user_profile '(record { user_id = "${userId}"; username = opt "${username}"; config = opt variant { admin = record { bio = opt "${bio}" } } })'
289289
```
290290

291+
To only upgrade a user to admin without changing any other properties:
292+
293+
```bash
294+
dfx canister call backend update_user_profile '(record { user_id = "${userId}"; config = opt variant { admin = record {} } })'
295+
```
296+
291297
To assign a user as a reviewer, run the following command:
292298

293299
- Replace `${userId}` with the ID of the profile that was created earlier.
@@ -316,10 +322,16 @@ dfx canister call backend update_user_profile '(record { user_id = "${userId}";
316322

317323
### Listing open proposals
318324

319-
To list open replica version management proposals:
325+
To list open IcOsVersionElection proposals:
326+
327+
```bash
328+
./scripts/list-open-ic-os-version-election-proposals.sh
329+
```
330+
331+
To list open IcOsVersionDeployment proposals on mainnet:
320332

321333
```bash
322-
./scripts/list-open-rvm-proposals.sh
334+
./scripts/list-open-ic-os-version-election-proposals.sh --ic
323335
```
324336

325337
### Creating closed proposals
@@ -366,33 +378,6 @@ To list open replica version management proposals:
366378
- `payload` is the Candid encoded argument for the corresponding NNS function. The types for this argument can be found in the appropriate canister's declaration. A mapping between NNS functions and their corresponding canisters can be found in the [`NnsFunction::canister_and_function`](https://github.com/dfinity/ic/blob/master/rs/nns/governance/src/governance.rs#L527-L631) function definition.
367379
- For example, the `UpdateElectedReplicaVersions` uses number `38` and its payload is the [`UpdateElectedReplicaVersionsPayload`](https://github.com/dfinity/ic/blob/master/rs/registry/canister/canister/registry.did#L217-L223) record.
368380

369-
### Getting proposals for testing
370-
371-
Open the [NNS canister interface on the dashboard](https://dashboard.internetcomputer.org/canister/rrkah-fqaaa-aaaaa-aaaaq-cai#list_proposals). It should open on the `list_proposals` method.
372-
373-
- Set `limit` to whatever you want, although lower numbers are recommended for a more manageable data set.
374-
- Set the `exclude_topic` length to `17`
375-
- Add the following topics to the `exclude_topic` list:
376-
- `0` for `Unspecified`
377-
- `1` for `NeuronManagement`
378-
- `2` for `ExchangeRate`
379-
- `3` for `NetworkEconomics`
380-
- `4` for `Governance`
381-
- `5` for `NodeAdmin`
382-
- `6` for `ParticipantManagement`
383-
- `7` for `SubnetManagement`
384-
- `8` for `NetworkCanisterManagement`
385-
- `9` for `Kyc`
386-
- `10` for `NodeProviderRewards`
387-
- `12` for `IcOsVersionDeployment`
388-
- `14` for `SnsAndCommunityFund`
389-
- `15` for `ApiBoundaryNodeManagement`
390-
- `16` for `SubnetRental`
391-
- `17` for `ProtocolCanisterManagement`
392-
- `18` for `ServiceNervousSystemManagement`
393-
- Note that `11` currently doesn't exist, and `13` is `IcOsVersionElection`, the topic we want.
394-
- Finally, click the `Call` button to get a list of proposals.
395-
396381
### Manually syncing proposals
397382

398383
To manually trigger the proposals synchronization from the Nervous Systems, run the following command:
@@ -402,3 +387,13 @@ dfx canister call backend sync_proposals
402387
```
403388

404389
This method can be called at any time, since if the proposals were already synced in the cron job, they won't be synced again.
390+
391+
## Updating Candid files for external canisters
392+
393+
To update the Candid files for external canisters, update the `RELEASE` variable in the `./scripts/update-scripts-canisters.sh` file. Make sure to also update referenced tag for the `ic-nns-governance` and `ic-nns-common` crates in the `Cargo.toml` file.
394+
395+
Then run the following script:
396+
397+
```bash
398+
./scripts/update-external-canisters.sh
399+
```

0 commit comments

Comments
 (0)