Skip to content

Commit 31270ee

Browse files
committed
Address the issues from the pull request comments again
1 parent a95ca14 commit 31270ee

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function getCardValue(card) {
1414
return 11;
1515
} else if (["J", "Q", "K"].includes(rank)) {
1616
return 10;
17-
} else if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 10) {
17+
} else if (!isNaN(rank) && rank >= 2 && rank <= 10) {
1818
return Number(rank);
1919
} else {
2020
return "Invalid card rank.";

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,12 @@ test("should return true for a proper fraction", () => {
99
// Case 2: Identify Improper Fractions:
1010
test("should return false for an improper fraction", () => {
1111
expect(isProperFraction(3, 2)).toEqual(false);
12-
});
13-
14-
test("should return false for an improper fraction", () => {
1512
expect(isProperFraction(-5, 3)).toEqual(false);
1613
});
1714

1815
// Case 3: Identify Negative Fractions:
1916
test("should return true for a negative fraction", () => {
2017
expect(isProperFraction(-4, 7)).toEqual(true);
21-
});
22-
23-
test("should return true for a negative fraction", () => {
2418
expect(isProperFraction(4, -7)).toEqual(true);
2519
});
2620

0 commit comments

Comments
 (0)