refactor password validation logic and enhance test coverage for various password criteria

Author: alexandru-pocovnicu

Sprint-3/3-stretch/password-validator.js

@@ -1,6 +1,30 @@
 function passwordValidator(password) {
-    return password.length < 5 ? false : true
+  //console.log(password !== password.toUpperCase());
+  let password2=password.split("")
+  console.log(password2);
+  let newPassword=[];
+  // if (
+  //   password.length >= 5 &&
+  //   password !== password.toLowerCase() &&
+  //   password !== password.toUpperCase() 
+    
+  // ) {
+  //   return true;
+  // }
+  for(element of password2){
+    if (
+      password2.length >= 5 &&
+      /[A-Za-z]/.test(password2) 
+      
+    ) {
+      return true;
+    }
+  }
+
+  return false;
 }
 
 
-module.exports = passwordValidator;
+console.log(passwordValidator("434398866"));
+
+module.exports = passwordValidator;

Sprint-3/3-stretch/password-validator.test.js

@@ -15,12 +15,46 @@ To be valid, a password must:
 You must breakdown this problem in order to solve it. Find one test case first and get that working
 */
 const isValidPassword = require("./password-validator");
+
 test("password has at least 5 characters", () => {
     // Arrange
-    const password = "12345";
+    const password = "As?123";
     // Act
     const result = isValidPassword(password);
     // Assert
     expect(result).toEqual(true);
 }
-);
+);
+test("password has at least 5 characters", () => {
+  const password = "As?3"; 
+  const result = isValidPassword(password);
+  expect(result).toEqual(false);
+});
+
+test("password has at least one English uppercase letter (A-Z)", () => {
+  const password = "As?123";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});
+test("password has at least one English uppercase letter (A-Z)", () => {
+  const password = "s?123";
+  const result = isValidPassword(password);
+  expect(result).toEqual(false);
+});
+
+test("password has at least one English lowercase letter (a-z)", () => {
+  const password = "'aK763";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});
+test("password has at least one English lowercase letter (a-z)", () => {
+  const password = "QWE<25365";
+  const result = isValidPassword(password);
+  expect(result).toEqual(false);
+});
+
+test("password has at least one number 0-9", () => {
+  const password = "QWE<25365";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});