Refactor isProperFraction function to improve zero denominator handling and simplify logic for proper fraction checks

Baba05206 · Baba05206 · commit debd98635d93 · 2025-10-29T15:42:45.000Z
diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -10,11 +10,9 @@
 function isProperFraction(numerator, denominator) {
   if (denominator === 0) {
     return "Invalid — denominator cannot be zero";
-  } else if (numerator * numerator < denominator * denominator) {
-    return true;
-  } else {
-    return false;
   }
+
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,9 @@`
`10`	`10`	`function isProperFraction(numerator, denominator) {`
`11`	`11`	`if (denominator === 0) {`
`12`	`12`	`return "Invalid — denominator cannot be zero";`
`13`		`- } else if (numerator * numerator < denominator * denominator) {`
`14`		`- return true;`
`15`		`- } else {`
`16`		`- return false;`
`17`	`13`	`}`
	`14`	`+`
	`15`	`+ return Math.abs(numerator) < Math.abs(denominator);`
`18`	`16`	`}`
`19`	`17`
`20`	`18`	`// The line below allows us to load the isProperFraction function into tests in other files.`