Fix the code

Refactor isProperFraction function to include input type checks and handle division by zero. Update logic to determine if a fraction is proper based on the value of the numerator and denominator.

Author: Alaa-Tagi

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,23 +8,20 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
+  if (typeof numerator !== "number" || typeof denominator !== "number") {
+    return false; // Invalid input types
+  }
+
   if (denominator === 0) {
-    return false; 
-  } 
-  return Math.abs(numerator) < Math.abs(denominator);
+    return false; // Division by zero is undefined
+  }
+
+  const value = numerator / denominator;
+  return Math.abs(value) < 1; // Proper fraction if the value is between -1 and 1
 }
 
-// The line below allows us to load the isProperFraction function into tests in other files.
-// This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
 
-// here's our helper again
-function assertEquals(actualOutput, targetOutput) {
-  console.assert(
-    actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
-  );
-}
 
 // Acceptance criteria:
 
@@ -99,4 +96,4 @@ denominator= -2;
 console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
 numerator= -3;
 denominator= -7;
-console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));